Skip to content

Support for baking reflections #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

solitaryurt
Copy link
Contributor

No description provided.

@solitaryurt
Copy link
Contributor Author

Still WIP, would love early feedback

@solitaryurt solitaryurt force-pushed the baked-reflections branch 2 times, most recently from ebffc61 to e2046c6 Compare January 20, 2025 19:30
@stechyo
Copy link
Owner

stechyo commented Jan 20, 2025

The title is certainly interesting! I am nowhere near a computer but I’ll try to look at this next Sunday. Thank you!!

@stechyo
Copy link
Owner

stechyo commented Feb 2, 2025

How are you calling start_bake() right now?

@solitaryurt
Copy link
Contributor Author

I hadn't gotten that far yet, but I was thinking about adding an EditorPlugin that we can use with a button to call that function.

Another addon named TBLoader does something similar where it has an EditorPlugin that calls a GDExtension function via a button:
https://github.com/codecat/godot-tbloader/blob/master/addons/tbloader/src/plugin.gd

image

Although I'm not entirely sure regarding the order of operations, I figure we'd need to setup the scene etc. before calling start_bake.

I haven't had time to get back to this yet, but hopefully soon!

@monxa
Copy link

monxa commented Feb 14, 2025

I am really looking forward to this, as last time I tried this plugin, performance was a slight bottleneck.

@TristanLMartin
Copy link

This is awesome, is the only blocker here at this point just trying to find a good way to initiate the baking of a scene?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants