generated from obsidianmd/obsidian-sample-plugin
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] The {{comment}} is not formatted correctly #161
Comments
你好,请问导出{{comment}}是否需要额外配置?我看默认配置会导出{{comment}},不过我生成的md一直只有{{highlight}} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
when I set the formmat of {{hightlight}} is "quotation marks", and set the formmat of {{comment}} is "Blockquote", the extracted annotation will like this:

You can find that that {{highlight}} part is correct, but in the {{comment}} part, there's a quotation mark in the beginning. But I didn't set "quotation marks" in the setting.
After checking the source code, I found the bug.
In line 5118~5120 of the main.js, the original code is:
will result that the commentFormatBefore is same as the highlightFormatBefore. So it should changed to:
What's more, there are also two little bugs:
(1) in line 4473,
highlightColouredBefore = '<mark style="background: SELECTED_COLOUR>';
there lacks a Double quotation marks before ">"
(2) in line 4495, the original code is
the sentence was incorrectly wrapped. It should changed to :
const commentFormatBefore = commentHighlighted + commentColouredBefore + commentBold + commentItalic + commentQuoteOpen;
The text was updated successfully, but these errors were encountered: