This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
API pagination page encourages array based request format #728
Assignees
Comments
|
Great catch!! I'll get a PR made for that ASAP |
ElliotFriend
added a commit
that referenced
this issue
Feb 22, 2024
|
I have this fixed in #743, and here's the relevant preview page: https://soroban-docs-pr743.previews.kube001.services.stellar-ops.com/api/pagination. I'll merge it in as soon as I get an approval 😁 |
ElliotFriend
added a commit
that referenced
this issue
Feb 22, 2024
ElliotFriend
added a commit
that referenced
this issue
Feb 23, 2024
ElliotFriend
added a commit
that referenced
this issue
Feb 23, 2024
ElliotFriend
added a commit
that referenced
this issue
Feb 23, 2024
* create redirects for tools and SDKs pages * adjust some redirect URLs to better reflect new stellar-docs pages * forgot a semicolon! * linking to migrated developer tools page * fine-tuning some redirects * add a list of "already migrated" stuff to the sidebar * remove SDKs content that's being migrated * fix the resulting broken links * Revert "remove SDKs content that's being migrated" This reverts commit 6dd2a28. * Revert "linking to migrated developer tools page" This reverts commit fc23408. * try this method of turning docs into external links * include soroban-cli page in the tools migration * change cli links to developer docs * use by-name params in pagination example (#743) Refs: #728
ElliotFriend
added a commit
that referenced
this issue
Feb 23, 2024
* add an announcement bar about the docs merge, and supporting styles * updated link to rpc helm chart values (#738) * Add v20.2.0 release to `releases.mdx` (#737) * Update releases.mdx * use latest versions * add changelog * update title * Update resource limits and make a new reference page for them (#736) * add a reference page on resource limits and fees * remove resource fee/limit tables from "explainer" page * removing some unnecessary comments and entries Some of the comments are more applicable in the discussion doc, than they are for developer documentation. So, let's get rid of those. * remove unnecessary "current is..." language from resource fees * use by-name params in pagination example (#743) Refs: #728 --------- Co-authored-by: shawn <sreuland@users.noreply.github.com> Co-authored-by: Julian Martinez <73849597+Julian-dev28@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The API pagination page encourages array based request format.
However, in stellar/stellar-rpc#13 we're deprecating and discouraging use of array based parameters because the feature is being removed from the RPC in v21.
The text was updated successfully, but these errors were encountered: