Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Use soroban contract init command in getting started tutorial #730

Merged
merged 16 commits into from
Mar 12, 2024
Merged

Use soroban contract init command in getting started tutorial #730

merged 16 commits into from
Mar 12, 2024

Conversation

elizabethengelman
Copy link
Contributor

@elizabethengelman elizabethengelman commented Feb 16, 2024 •
edited
Loading

This PR updates the getting started tutorial to use soroban contract init to create a new project, which streamlines the getting started process for new users.

This PR is dependent on the following PRs:

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

@elizabethengelman elizabethengelman force-pushed the use-init-in-getting-started branch from 2ed044f to a2d51cd Compare February 19, 2024 17:28
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

@elizabethengelman elizabethengelman force-pushed the use-init-in-getting-started branch from a2d51cd to 16827f0 Compare February 27, 2024 22:15
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@elizabethengelman elizabethengelman force-pushed the use-init-in-getting-started branch from 16827f0 to 82c4077 Compare February 28, 2024 15:30
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@elizabethengelman elizabethengelman mentioned this pull request Feb 28, 2024
Merged
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

@elizabethengelman elizabethengelman marked this pull request as ready for review February 29, 2024 21:47
ElliotFriend
ElliotFriend reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really great! I left a few questions, comments, and nitpicks, though this represents an amazing improvement!

Thank you!

@ElliotFriend
Copy link
Contributor

While we're updating the tutorial, can we update the CLI output in the installation part? https://soroban.stellar.org/docs/getting-started/setup#usage

I think it's reflecting an older version and older options in the CLI

@elizabethengelman @ElliotFriend
Apply suggestions from code review
3b95639 
Co-authored-by: Elliot Voris <elliot@voris.me>
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

@elizabethengelman @ElliotFriend
Update re-installing to enable opt to not include version
c35477b 
Co-authored-by: Elliot Voris <elliot@voris.me>
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

@elizabethengelman elizabethengelman mentioned this pull request Mar 4, 2024
Merged
@elizabethengelman @ElliotFriend
Update docs/getting-started/setup.mdx
dd74a83 
Co-authored-by: Elliot Voris <elliot@voris.me>
@elizabethengelman elizabethengelman force-pushed the use-init-in-getting-started branch from c8b7498 to dd74a83 Compare March 4, 2024 23:23
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

1 similar comment
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

@elizabethengelman elizabethengelman force-pushed the use-init-in-getting-started branch from 24c6ec1 to 7753326 Compare March 4, 2024 23:36
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

1 similar comment
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

@elizabethengelman elizabethengelman force-pushed the use-init-in-getting-started branch from e572203 to 49a67ab Compare March 4, 2024 23:54
@elizabethengelman elizabethengelman force-pushed the use-init-in-getting-started branch from 49a67ab to 54f3ffd Compare March 4, 2024 23:56
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

3 similar comments
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

@ElliotFriend ElliotFriend mentioned this pull request Mar 5, 2024
Merged
@stellar-jenkins
Copy link

Preview is available here:
http://soroban-docs-pr730.previews.kube001.services.stellar-ops.com/

ElliotFriend
ElliotFriend approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! Thanks so much for the work on this!!

@ElliotFriend ElliotFriend merged commit 42faf1d into stellar-deprecated:main Mar 12, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ElliotFriend ElliotFriend ElliotFriend approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elizabethengelman @stellar-jenkins @ElliotFriend