Bottom Tab with initial screens #2
Conversation
src/config/theme.ts
Outdated
| @@ -0,0 +1,19 @@ | |||
| export const COLORS = { | |||
There was a problem hiding this comment.
Do you think it would make sense to try to get close to the conventions in the SDS?
Like making primary/secondary/etc identifiers at a global level and having primitives for font size/weight, etc.
There was a problem hiding this comment.
great idea, I'll port over this theme file to the project
| // Use throughout your app instead of plain `useDispatch` and `useSelector` | ||
| export const useDispatch = () => useReduxDispatch<Dispatch>(); | ||
| export const useSelector: TypedUseSelectorHook<RootState> = useReduxSelector; | ||
| export const useStore = () => useReduxStore<Store>(); |
There was a problem hiding this comment.
Cassio and I talked about this briefly over DM, but we may want to consider sharing reducers between extension and mobile. It would be nice to be dealing with the the same actions and similarly shaped data when retrieving account info, for example
There was a problem hiding this comment.
Thanks for bringing this up. I think having similarly shaped data would be nice and could be helpful with code/logic understanding between the 2 products. But I'm also a bit worried that it could get in the way sometimes, since web and mobile have their differences as well. I'd say we could try mimicking each other whenever possible as a suggested approach but also have the flexibility to diverge from each other. Wdyt?
when retrieving account info, for example
@piyalbasu would you mind linking here the extension actions for retrieving account info that you have in mind so we could take a look as an example?
Thanks!
There was a problem hiding this comment.
I think we can keep discussing it offline and also during the next PRs, I'll merge this one now so we can keep moving! :)
There was a problem hiding this comment.
yeah I'd lean to not do this so we don't inherit the store patterns we have in Freighter today, we've had trouble getting the desired UX out of the usage of our store in the past and are currently refactoring some big parts of the store away from it and into hooks(history/balances).
CassioMG
force-pushed
the
cg-setup-folders
branch
from
9da0cf7 to
85ebe9d
Compare
This PR creates a
folder structurealong with a initial rough version for theBottom Tabwith 4 tabs:Home,Swap,HistoryandSettings. It also includesLoginandSign outbuttons along with a network detector which displays aNo internet connectionbanner.This PR also ports the
Buttoncomponent fromSDStoreact-nativealong with its correspondingButton/theme.tsfile also ported fromSDS.Also included in this PR:
FreighterMobiletofreighter-mobilefor naming consistency across other stellar projectsstyled-componentsfor UI stylingredux storeandreducernavigatorsandroutesBaseLayoutcomponent that should be used to wrap all screensdimensionshelper to automatically resize components, fonts and spacing based on device screen sizedebughelper for better dev experiencethemevalues from SDSScreen.Recording.2025-02-12.at.17.02.16.mov