adds scrubPathGKey tests and tweaks scrubber

extension/src/popup/helpers/__tests__/formatters.test.js

@@ -1,5 +1,5 @@
 import BigNumber from "bignumber.js";
-import { formatAmount } from "../formatters";
+import { formatAmount, scrubPathGkey } from "../formatters";
 import { formatTokenAmount } from "../soroban";
 
 describe("formatAmount", () => {
@@ -15,3 +15,27 @@ describe("formatAmount", () => {
     expect(formatTokenAmount(value, 7)).toBe(formatted);
   });
 });
+
+describe("scrubPathGkey", () => {
+  const ADDRESS = "GCBDC5AVPZEOSO3IAASQZSVRJMHX3UCCZH5O7S53FPZ636LQ5RHEW65H";
+  it("should redact a G address from a URL", () => {
+    const route = "account-history/";
+    const url =
+      "http://0.0.0.0:3002/api/v1/account-history/GCBDC5AVPZEOSO3IAASQZSVRJMHX3UCCZH5O7S53FPZ636LQ5RHEW65H?network=PUBLIC";
+    const expected =
+      "http://0.0.0.0:3002/api/v1/account-history/REDACTED?network=PUBLIC";
+    expect(scrubPathGkey(route, url)).toBe(expected);
+  });
+  it("should redact a G address from a URL with no query params", () => {
+    const route = "account-history/";
+    const url =
+      "http://0.0.0.0:3002/api/v1/account-history/GCBDC5AVPZEOSO3IAASQZSVRJMHX3UCCZH5O7S53FPZ636LQ5RHEW65H";
+    const expected = "http://0.0.0.0:3002/api/v1/account-history/REDACTED";
+    expect(scrubPathGkey(route, url)).toBe(expected);
+  });
+  it("should return the URL in cases where it cannot redact", () => {
+    const route = "account-history/";
+    const url = "not-even-a-url";
+    expect(scrubPathGkey(route, url)).toBe(url);
+  });
+});

extension/src/popup/helpers/formatters.ts

@@ -100,7 +100,11 @@ export const formattedBuffer = (data: Buffer) =>
   truncatedPublicKey(Buffer.from(data).toString("hex").toUpperCase());
 
 export const scrubPathGkey = (route: string, url: string) => {
-  const start = url.indexOf(route);
-  const end = url.indexOf("?");
-  return url.substring(start + route.length) + "REDACTED" + url.substring(end);
+  try {
+    const [base, slug] = url.split(route);
+    const end = slug.indexOf("?") === -1 ? slug.length : slug.indexOf("?");
+    return `${base}${route}` + "REDACTED" + slug.substring(end);
+  } catch (error) {
+    return url;
+  }
 };