From c129cb998f0e00ebd439ea6d29b423183bae8865 Mon Sep 17 00:00:00 2001 From: Aristides Staffieri Date: Mon, 19 Aug 2024 10:08:08 -0600 Subject: [PATCH] fixes lint warnings --- @shared/api/internal.ts | 1 - extension/src/popup/components/ErrorTracking/index.tsx | 4 +++- extension/src/popup/helpers/formatters.ts | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/@shared/api/internal.ts b/@shared/api/internal.ts index 54d7926fbd..4bea9b8e39 100644 --- a/@shared/api/internal.ts +++ b/@shared/api/internal.ts @@ -453,7 +453,6 @@ export const getAccountIndexerBalances = async ( } if ("error" in data && (data?.error?.horizon || data?.error?.soroban)) { - const _err = JSON.stringify(data.error); captureException( `Failed to fetch account balances - ${response.status}: ${response.statusText}`, ); diff --git a/extension/src/popup/components/ErrorTracking/index.tsx b/extension/src/popup/components/ErrorTracking/index.tsx index a9cc99fda4..0a3ef31339 100644 --- a/extension/src/popup/components/ErrorTracking/index.tsx +++ b/extension/src/popup/components/ErrorTracking/index.tsx @@ -5,8 +5,8 @@ import { Integrations } from "@sentry/tracing"; import { SENTRY_KEY } from "constants/env"; import { settingsDataSharingSelector } from "popup/ducks/settings"; import { scrubPathGkey } from "popup/helpers/formatters"; -import packageJson from "../../../../package.json"; import { INDEXER_URL } from "@shared/constants/mercury"; +import packageJson from "../../../../package.json"; export const ErrorTracking = () => { const isDataSharingAllowed = useSelector(settingsDataSharingSelector); @@ -30,12 +30,14 @@ export const ErrorTracking = () => { if (url?.includes(`${INDEXER_URL}/account-history`)) { const route = "account-history/"; const scrubbedUrl = scrubPathGkey(route, url); + // eslint-disable-next-line no-param-reassign event.request.url = scrubbedUrl; } if (url?.includes(`${INDEXER_URL}/account-balances`)) { const route = "account-balances/"; const scrubbedUrl = scrubPathGkey(route, url); + // eslint-disable-next-line no-param-reassign event.request.url = scrubbedUrl; } diff --git a/extension/src/popup/helpers/formatters.ts b/extension/src/popup/helpers/formatters.ts index f8dc03c481..a8ad8521e5 100644 --- a/extension/src/popup/helpers/formatters.ts +++ b/extension/src/popup/helpers/formatters.ts @@ -103,7 +103,7 @@ export const scrubPathGkey = (route: string, url: string) => { try { const [base, slug] = url.split(route); const end = slug.indexOf("?") === -1 ? slug.length : slug.indexOf("?"); - return `${base}${route}` + "REDACTED" + slug.substring(end); + return `${base}${route}${"REDACTED"}${slug.substring(end)}`; } catch (error) { return url; }