Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Freighter Beta v5.28 #1845

Open
sdfcharles opened this issue Feb 11, 2025 · 4 comments
Open

QA Freighter Beta v5.28 #1845

sdfcharles opened this issue Feb 11, 2025 · 4 comments
Assignees

Comments

@sdfcharles
Copy link

sdfcharles commented Feb 11, 2025

Image
is there anyway to handle claimable balances in history better? we have this in the designs where claimable balances are separated and put in another screen.
Image

Image
broken image link, should be the placeholder broken link

Image
when i add a malicious token that has been flagged by Blockaid, and I click "Add anyway" i see this screen and then I have to close Freighter and open it back up again. i think we still let users add anyway right?

@sdfcharles sdfcharles self-assigned this Feb 11, 2025
@sdfcharles
Copy link
Author

sdfcharles commented Feb 11, 2025

visual QA done cc @JakeUrban @aristidesstaffieri @piyalbasu @CassioMG

@piyalbasu
Copy link
Contributor

Thanks - we do actually already have a ticket for the add asset error: #1793 We should prioritize this in our next sprint

@JakeUrban
Copy link
Contributor

is there anyway to handle claimable balances in history better? we have this in the designs where claimable balances are separated and put in another screen.

Lets tackle this in a separate ticket. In the short term, lets just filter this stuff out -- its all spam, and Freighter doesn't provide a way to claim these balances from within the extension anyway.

If/when we do decide to prioritize claiming balance, I like your design @sdfcharles, but it feels a bit odd to have the pending screen accessible from the history tab. I figured it would be discoverable from the home/balances view, wdyt?

@piyalbasu
Copy link
Contributor

Btw, we do also have this ticket for adding pending transactions as a separate feature: #1794

@sdfcharles sdfcharles assigned piyalbasu and unassigned sdfcharles Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants