Fix/replace alert #1847
Merged
Fix/replace alert #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyalbasu
commented
Feb 12, 2025
| @@ -1405,7 +1404,7 @@ export const BlockaidAssetScanLabel = ({ | |||
|
|
|||
| return ( | |||
| <BlockaidWarningModal | |||
| header={`This asset was flagged as ${blockaidData.result_type}`} | |||
| header={`This asset was flagged as ${blockaidData.result_type.toLowerCase()}`} | |||
There was a problem hiding this comment.
slightly unrelated - but I just noticed that occasionally we use uppercase and lower case when denoting something as malicious, so making sure it's uniform throughout
piyalbasu
commented
Feb 12, 2025
| address={address} | ||
| /> | ||
| </Alert> | ||
| <div className="ScamAssetWarning__box__content"> |
There was a problem hiding this comment.
Since this is a temporary fix (we should be able to use the Alert component in the future), I'm re-using the styles we use on the other Blockaid warnings
|
I don't want my question / comment to block this work, but it seems redundant to show two warnings for a transaction (one for the transaction, another for the asset). Is there a way to determine if a transaction is flagged as malicious due to a malicious asset being transacted? Or is it blockaid's policy that all transactions that use malicious assets are malicious? If either are true, it feels like we should be showing one warning, rather than two, that communicates the asset being transacted is malicious. Maliciousness of the transaction is a transitive property in this case. What do you think @sdfcharles ? |
|
@JakeUrban hmm good point, agreed would be nice if it was only one error so wondering about the above questions as well. cc @piyalbasu
|
Let's chat with Blockaid about this. They mentioned today that they'll be starting to provide UX best practices for wallets, which I think this fits under. Until we have a clearer answer from them, I'd be hesitant to try to be too smart with hiding any warning. Fwiw, the tx warning just tells you that the token is malicious, but the asset warning tells you why the token is malicious |
I agree that this shouldn't be a part of this change set but I do wonder if we can aggregate blockaid response types by type so we at most show 1 "malicious" warning for example, where in the details we expose both the asset and tx details from each response item. |
aristidesstaffieri
approved these changes
Feb 12, 2025
aristidesstaffieri
added a commit
that referenced
this pull request
Feb 20, 2025
* Redesign Account History (#1785) * Remove leftovers * Move stellarExpertUrl to inside HistoryItem * Display amounts using Badge component * Date font size and color # Conflicts: # extension/src/popup/components/accountHistory/HistoryItem/styles.scss * Make formatted amount label consistent between History item and Tx detail components * Fix isRecieving => isReceiving typo * Redesign "payment" row * Redesign "swap" payment * Use SVG for history icons * Swapped label * Use SDS Icon components * format * Remove history segments * Use Text SDS component + refactor some styling * Renaming * Swap icons with placeholders * center swap icons * Icons for soroban operations * Remove a few spaces to keep consistency * Don't show small icon for generic transactions * Handle CreateAccount and ChangeTrust operations # Conflicts: # extension/src/popup/components/accountHistory/HistoryItem/index.tsx * Separate history in month sections + use SDS Text component to render headers * clean up * Displays actual month name * getHistoryState => historyState renaming * Delete HistoryList component Is not adding much value currently * Use AppHeader component * Tweak section margin * tweak bottom margin * Use index to get last section instead of mutating the array * Use more descriptive names to color classes * Remove Account ternaries * Leave amount field blank instead of displaying "N/A" label * Use "tertiary" variant for Send and Swap buttons # Conflicts: # extension/src/popup/components/account/AssetDetail/index.tsx * Reduce Badge max width * Add translations * Fix test id * Add key to list item * Drop ticker on balances view * Fix tests * Prevent null pointer when attrs is null * Fix icon for mint and transfer invocations * Fix "false" appearing as amount sign * Fix tests * Extract isDustPayment to a helper * Display stellar logo for XLM transfer invocations * Use pxToRem * Use pxToRem * Use pxToRem * adding blockaid byline and feedback form (#1767) * Bump @stellar/design-system in /extension (#1729) Bumps [@stellar/design-system](https://github.com/stellar/stellar-design-system) from 2.0.0-beta.15 to 2.0.0-beta.17. - [Release notes](https://github.com/stellar/stellar-design-system/releases) - [Commits](https://github.com/stellar/stellar-design-system/commits) --- updated-dependencies: - dependency-name: "@stellar/design-system" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * adding blockaid byline and feedback form * fix tests * Added translations --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * “Add Token” via freighter-api (#1815) * First cut on data flow * Fix lint warnings * Clean up * Only enable button if asset found * If there is an asset, display it right away * Add missing network param * Guard against missing contract id * Make sure popup is always closed * Use publicKeySelector instead * No need for backwards compatibility on new method * Default to tx's network passphrase * Return contractId on success * Default to Mainnet passphrase * Add tests * Use Type definition for input and output * Disable rule only on necessary spots * Let optional params be optional * First cut on UI * only display info when it exists * Display token image when available * Display "Asset on your lists" notification * Fetch asset name from TOML * Prevent infinity spinner * Fetch and display balance * Display error if id not valid * Add/update docs * Missing addToken documentation * Missing getNetworkDetails documentation * "Simulated Balance Changes" => "Balance Info" * Fetch token balance using freighter-backend instead of soroban rpc * Fix/replace alert (#1847) * reusing an existing notification style to redesign the blockaid Alert notification * make sure warnings match case and fix row gap * update testid --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
aristidesstaffieri
added a commit
that referenced
this pull request
Feb 21, 2025
* Redesign Account History (#1785) * Remove leftovers * Move stellarExpertUrl to inside HistoryItem * Display amounts using Badge component * Date font size and color * Make formatted amount label consistent between History item and Tx detail components * Fix isRecieving => isReceiving typo * Redesign "payment" row * Redesign "swap" payment * Use SVG for history icons * Swapped label * Use SDS Icon components * format * Remove history segments * Use Text SDS component + refactor some styling * Renaming * Swap icons with placeholders * center swap icons * Icons for soroban operations * Remove a few spaces to keep consistency * Don't show small icon for generic transactions * Handle CreateAccount and ChangeTrust operations * Separate history in month sections + use SDS Text component to render headers * clean up * Displays actual month name * getHistoryState => historyState renaming * Delete HistoryList component Is not adding much value currently * Use AppHeader component * Tweak section margin * tweak bottom margin * Use index to get last section instead of mutating the array * Use more descriptive names to color classes * Remove Account ternaries * Leave amount field blank instead of displaying "N/A" label * Use "tertiary" variant for Send and Swap buttons * Reduce Badge max width * Add translations * Fix test id * Add key to list item * Drop ticker on balances view * Fix tests * Prevent null pointer when attrs is null * Fix icon for mint and transfer invocations * Fix "false" appearing as amount sign * Fix tests * Extract isDustPayment to a helper * Display stellar logo for XLM transfer invocations * Use pxToRem * Use pxToRem * Use pxToRem * adding blockaid byline and feedback form (#1767) * Bump @stellar/design-system in /extension (#1729) Bumps [@stellar/design-system](https://github.com/stellar/stellar-design-system) from 2.0.0-beta.15 to 2.0.0-beta.17. - [Release notes](https://github.com/stellar/stellar-design-system/releases) - [Commits](https://github.com/stellar/stellar-design-system/commits) --- updated-dependencies: - dependency-name: "@stellar/design-system" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * adding blockaid byline and feedback form * fix tests * Added translations --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * “Add Token” via freighter-api (#1815) * First cut on data flow * Fix lint warnings * Clean up * Only enable button if asset found * If there is an asset, display it right away * Add missing network param * Guard against missing contract id * Make sure popup is always closed * Use publicKeySelector instead * No need for backwards compatibility on new method * Default to tx's network passphrase * Return contractId on success * Default to Mainnet passphrase * Add tests * Use Type definition for input and output * Disable rule only on necessary spots * Let optional params be optional * First cut on UI * only display info when it exists * Display token image when available * Display "Asset on your lists" notification * Fetch asset name from TOML * Prevent infinity spinner * Fetch and display balance * Display error if id not valid * Add/update docs * Missing addToken documentation * Missing getNetworkDetails documentation * "Simulated Balance Changes" => "Balance Info" * Fetch token balance using freighter-backend instead of soroban rpc * Fix/replace alert (#1847) * reusing an existing notification style to redesign the blockaid Alert notification * make sure warnings match case and fix row gap * update testid --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
aristidesstaffieri
added a commit
that referenced
this pull request
Feb 21, 2025
* Bump the major group across 5 directories with 83 updates --- updated-dependencies: - dependency-name: "@testing-library/dom" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@testing-library/jest-dom" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@types/testing-library__jest-dom" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@typescript-eslint/parser" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: eslint dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: eslint-config-prettier dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: eslint-import-resolver-typescript dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: eslint-plugin-flowtype dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: eslint-plugin-react-hooks dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: glob dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: got dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: husky dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: isomorphic-unfetch dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: jest dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@types/jest" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: jsdom dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: lint-staged dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: prettier dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: pretty-quick dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: typescript dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: webpack-cli dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: webpack-merge dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@lavamoat/allow-scripts" dependency-type: direct:development update-type: version-update:semver-major dependency-group: major - dependency-name: "@lavamoat/preinstall-always-fail" dependency-type: direct:development update-type: version-update:semver-major dependency-group: major - dependency-name: eslint-plugin-jsdoc dependency-type: direct:development update-type: version-update:semver-major dependency-group: major - dependency-name: clsx dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: react dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@types/react" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: react-dom dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@types/react-dom" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: react-is dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: styled-components dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@reduxjs/toolkit" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@testing-library/react" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@testing-library/user-event" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@types/jsdom" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@types/node" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@types/react-copy-to-clipboard" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@types/testing-library__jest-dom" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: concurrently dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: history dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@types/history" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: i18next dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: i18next-browser-languagedetector dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: jest-environment-jsdom dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: qrcode.react dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: react-i18next dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: react-redux dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: react-router-dom dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: redux dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: sass-loader dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: ses dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@sentry/webpack-plugin" dependency-type: direct:development update-type: version-update:semver-major dependency-group: major - dependency-name: "@stellar/prettier-config" dependency-type: direct:development dependency-group: major - dependency-name: prettier dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: typescript dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@lavamoat/allow-scripts" dependency-type: direct:development update-type: version-update:semver-major dependency-group: major - dependency-name: "@stellar/js-xdr" dependency-type: direct:production dependency-group: major - dependency-name: bignumber.js dependency-type: direct:production dependency-group: major - dependency-name: "@stellar/prettier-config" dependency-type: direct:development dependency-group: major - dependency-name: typescript dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: bignumber.js dependency-type: direct:production dependency-group: major - dependency-name: "@lavamoat/allow-scripts" dependency-type: direct:development update-type: version-update:semver-major dependency-group: major - dependency-name: "@types/react" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@types/react-dom" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: prettier dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: pretty-quick dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@lavamoat/allow-scripts" dependency-type: direct:development update-type: version-update:semver-major dependency-group: major - dependency-name: bignumber.js dependency-type: direct:production dependency-group: major - dependency-name: react dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: react-dom dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@ledgerhq/hw-app-str" dependency-type: direct:production dependency-group: major - dependency-name: "@ledgerhq/hw-transport-webusb" dependency-type: direct:production dependency-group: major - dependency-name: "@reduxjs/toolkit" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@sentry/browser" dependency-type: direct:production dependency-group: major - dependency-name: "@stellar/typescript-wallet-sdk-km" dependency-type: direct:production dependency-group: major - dependency-name: "@testing-library/react" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@testing-library/user-event" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@types/history" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@types/jsdom" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@types/lodash" dependency-type: direct:production dependency-group: major - dependency-name: "@types/node" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@types/qrcode.react" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@types/react-copy-to-clipboard" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: "@types/react-redux" dependency-type: direct:production dependency-group: major - dependency-name: "@types/react-router-dom" dependency-type: direct:production dependency-group: major - dependency-name: "@types/testing-library__jest-dom" dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: concurrently dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: dotenv-webpack dependency-type: direct:production dependency-group: major - dependency-name: formik dependency-type: direct:production dependency-group: major - dependency-name: history dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: html-loader dependency-type: direct:production dependency-group: major - dependency-name: html-webpack-plugin dependency-type: direct:production dependency-group: major - dependency-name: i18next dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: i18next-browser-languagedetector dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: i18next-resources-to-backend dependency-type: direct:production dependency-group: major - dependency-name: jest-canvas-mock dependency-type: direct:production dependency-group: major - dependency-name: jest-environment-jsdom dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: jsonschema dependency-type: direct:production dependency-group: major - dependency-name: lodash dependency-type: direct:production dependency-group: major - dependency-name: mini-css-extract-plugin dependency-type: direct:production dependency-group: major - dependency-name: prop-types dependency-type: direct:production dependency-group: major - dependency-name: punycode dependency-type: direct:production dependency-group: major - dependency-name: qrcode.react dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: react-copy-to-clipboard dependency-type: direct:production dependency-group: major - dependency-name: react-i18next dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: react-redux dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: react-router-dom dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: redux dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: sass dependency-type: direct:production dependency-group: major - dependency-name: sass-loader dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: semver dependency-type: direct:production dependency-group: major - dependency-name: ses dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: tsconfig-paths-webpack-plugin dependency-type: direct:production dependency-group: major - dependency-name: yup dependency-type: direct:production dependency-group: major - dependency-name: "@sentry/webpack-plugin" dependency-type: direct:development update-type: version-update:semver-major dependency-group: major - dependency-name: "@types/semver" dependency-type: direct:development dependency-group: major - dependency-name: terser-webpack-plugin dependency-type: direct:development dependency-group: major - dependency-name: thread-loader dependency-type: direct:development dependency-group: major ... Signed-off-by: dependabot[bot] <support@github.com> * upgrades all syntax for breaking changes * updates test harness and syntax for new major versions, updates Router patterns to work in v7 * migrate navigateTo to use v7 API, fix tests for send payment * updates account tests for new router model * updates account creator tests for new router model * updates account history tests for new router model * updates grant access tests for new router model * updates manage assets tests for new router model * updates mnemonic phrase tests for new router model * updates review auth tests for new router model * updates send token payment tests for new router model * updates sign tx tests for new router model * updates swap tests for new router model * updates swap unfunded tests for new router model * updates operation keyval tests for new router model * catches up e2e tests to upstream changes * bumps node version in CI to 22 * cleans up imports in ManageAssets test, adds jest dom types to API ts config * temporarily dont fail on eslint failure * fixes routing logic for nested routes * disable eslint - temporary * fixes nested routing path handling for router v7, disables tests that rely on nested routing * updates test ID reference in e2e payment tests * bumps docs node engine to >=22 * trigger build to retry docs preview * bumps node version in npm rc for docs * restores swap index route * properly handle second level nested routed for settings * adds getPathFromRoute to clean up sub routing changes * upgrades all actions to use node version 22 * removes stray comment from refactor * redo eslint, prettier, ts configs to be compatible with new major versions * release/5.27.2 (#1827) (#1828) * Feature/memory security improvement 5.27.2 (#1827) * add temporary store extra data * add tests for switching accounts * reset session length * upgrade jest and add unit tests * rm unused selectors * fix sendpayment test * rm npm package and add unit tests * add better error handling and Sentry capture * rm console.log * make sure to login before adding new stellar address * add a test for imported S key payment * Fix/import acct when timed out (#1832) * make sure to login to all accounts before importing by private key if session has timed out * update comment * login before showing mnemonic phrase (#1834) * login before showing mnemonic phrase * add more Sentry error capture * bump versions to 5.27.2 (#1837) * Release 5.28.0 (#1798) * Redesign Account History (#1785) * Remove leftovers * Move stellarExpertUrl to inside HistoryItem * Display amounts using Badge component * Date font size and color * Make formatted amount label consistent between History item and Tx detail components * Fix isRecieving => isReceiving typo * Redesign "payment" row * Redesign "swap" payment * Use SVG for history icons * Swapped label * Use SDS Icon components * format * Remove history segments * Use Text SDS component + refactor some styling * Renaming * Swap icons with placeholders * center swap icons * Icons for soroban operations * Remove a few spaces to keep consistency * Don't show small icon for generic transactions * Handle CreateAccount and ChangeTrust operations * Separate history in month sections + use SDS Text component to render headers * clean up * Displays actual month name * getHistoryState => historyState renaming * Delete HistoryList component Is not adding much value currently * Use AppHeader component * Tweak section margin * tweak bottom margin * Use index to get last section instead of mutating the array * Use more descriptive names to color classes * Remove Account ternaries * Leave amount field blank instead of displaying "N/A" label * Use "tertiary" variant for Send and Swap buttons * Reduce Badge max width * Add translations * Fix test id * Add key to list item * Drop ticker on balances view * Fix tests * Prevent null pointer when attrs is null * Fix icon for mint and transfer invocations * Fix "false" appearing as amount sign * Fix tests * Extract isDustPayment to a helper * Display stellar logo for XLM transfer invocations * Use pxToRem * Use pxToRem * Use pxToRem * adding blockaid byline and feedback form (#1767) * Bump @stellar/design-system in /extension (#1729) Bumps [@stellar/design-system](https://github.com/stellar/stellar-design-system) from 2.0.0-beta.15 to 2.0.0-beta.17. - [Release notes](https://github.com/stellar/stellar-design-system/releases) - [Commits](https://github.com/stellar/stellar-design-system/commits) --- updated-dependencies: - dependency-name: "@stellar/design-system" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * adding blockaid byline and feedback form * fix tests * Added translations --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * “Add Token” via freighter-api (#1815) * First cut on data flow * Fix lint warnings * Clean up * Only enable button if asset found * If there is an asset, display it right away * Add missing network param * Guard against missing contract id * Make sure popup is always closed * Use publicKeySelector instead * No need for backwards compatibility on new method * Default to tx's network passphrase * Return contractId on success * Default to Mainnet passphrase * Add tests * Use Type definition for input and output * Disable rule only on necessary spots * Let optional params be optional * First cut on UI * only display info when it exists * Display token image when available * Display "Asset on your lists" notification * Fetch asset name from TOML * Prevent infinity spinner * Fetch and display balance * Display error if id not valid * Add/update docs * Missing addToken documentation * Missing getNetworkDetails documentation * "Simulated Balance Changes" => "Balance Info" * Fetch token balance using freighter-backend instead of soroban rpc * Fix/replace alert (#1847) * reusing an existing notification style to redesign the blockaid Alert notification * make sure warnings match case and fix row gap * update testid --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump versions to 5.28.0 (#1862) * docs(): bumping release to 5.28.0 * trigger CI --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Aristides Staffieri <aristides.staffieri@stellar.org> * Bump @stellar/freighter-api version to (#1864) * @stellar/freighter-api: bumping version to 3.1.0 * [create-pull-request] automated change * trigger CI --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: aristidesstaffieri <6886006+aristidesstaffieri@users.noreply.github.com> Co-authored-by: Aristides Staffieri <aristides.staffieri@stellar.org> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: aristidesstaffieri <6886006+aristidesstaffieri@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1846
Until the new
<Alert />component gets moved to SDS, we'll need to do some custom styling to match the existing design