add 24 word mnemonic phrase to recover-account #1070
Conversation
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
| @@ -6,7 +6,7 @@ | |||
| position: fixed; | |||
| top: 0; | |||
| width: 100%; | |||
| transition: opacity var(--anim-transition-default); | |||
| transition: opacity var(--dropdown-animation); | |||
There was a problem hiding this comment.
apparently this var doesn't exist in the repo anymore, so replacing it with this other animation timing var
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
* docs(): bumping release to 5.12.1 * Empty-Commit --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com>
…24-word-mnemonic # Conflicts: # jest.config.js
| ...options, | ||
| // Use packageFilter to process parsed `package.json` before the resolution (see https://www.npmjs.com/package/resolve#resolveid-opts-cb) | ||
| packageFilter: (pkg) => { | ||
| if (pkg.name === "@stellar/design-system") { |
There was a problem hiding this comment.
interesting use-case here:
Webpack/Rollup default to using the file listed under module in package.json, but Jest uses main. I set this up because I'd like Jest to use the same file path that Webpack will be using
| @@ -12,9 +12,6 @@ | |||
| "extension", | |||
| "@stellar/freighter-api" | |||
| ], | |||
| "resolutions": { | |||
| "**/terser-webpack-plugin": "^1.4.3" | |||
There was a problem hiding this comment.
Webpack 5 comes with a newer version of this included. This was causing an issue as this old version of Terser contained an outdated JS spec
| await page.locator(".RecoverAccount__phrase-toggle > label").click(); | ||
|
|
||
| // time out to accomodate animation | ||
| await page.waitForTimeout(150); |
There was a problem hiding this comment.
this probably works well enough but wanted to point out that there is also page.waitForSelector('yourselector') and page.waitForLoadState('domcontentloaded') which could give you less of a racy condition to wait for in the case of waiting for css animations.
There was a problem hiding this comment.
Ah, nice! That's much better. I was not psyched about doing this, but couldn't get it to work reliably otherwise
* Bump follow-redirects from 1.15.2 to 1.15.4 (#1080) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump follow-redirects from 1.15.2 to 1.15.4 in /docs (#1079) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add 24 word mnemonic phrase to recover-account (#1070) * add 24 word mnemonic phrase to recover-account * resolve to `module` entrypoint in SDS * Bump versions to 5.12.1 (#1076) * docs(): bumping release to 5.12.1 * Empty-Commit --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Piyal Basu <pbasu235@gmail.com> * combine steps in order to dedupe build steps * adds playwright browser install step * undo early merge * undo jest upgrade * revert yarn * yarn.lock for sds * fix out of date terser plugin * add test * add comment * rm race condition in test --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: aristides <aristides.staffieri@stellar.org> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: aristides <aristides.staffieri@stellar.org>
Screen.Recording.2023-12-22.at.6.11.31.PM.mov