[BUG] https check sign blob #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyalbasu
approved these changes
Jan 2, 2024
piyalbasu
added a commit
that referenced
this pull request
Jan 2, 2024
aristidesstaffieri
added a commit
that referenced
this pull request
Jan 10, 2024
aristidesstaffieri
added a commit
that referenced
this pull request
Jan 11, 2024
* [BUG] https check sign blob (#1074) (#1075) * uses full url to check for https on sign blob interaction * Added translations * remves file accidentally added by transalations hook Co-authored-by: aristides <aristides.staffieri@stellar.org> * adds remaining onboarding tests, cleans up fixtures * cleans up test fixtures, removes excperimental react playwright package, removes action workflow, not ready * ignore playwright tests in CI for now * adds snapshot tests, cleans up debug logs * update ignore pattern for e2e in jest target --------- Co-authored-by: Piyal Basu <pbasu235@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the broken check for a site using https during the sign blob interaction, it was using the domain instead of the full URL.