Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] https check sign blob #1074

Merged
merged 3 commits into from
Jan 2, 2024
Merged

[BUG] https check sign blob #1074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a848cb
uses full url to check for https on sign blob interaction
aristidesstaffieri Jan 2, 2024
70fa375
Added translations
aristidesstaffieri Jan 2, 2024
5181b40
remves file accidentally added by transalations hook
aristidesstaffieri Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions extension/src/popup/locales/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,9 @@
"The website <1>{{domain}}</1> does not use an SSL certificate": {
" For additional safety Freighter only works with websites that provide an SSL certificate": "The website <1>{{domain}}</1> does not use an SSL certificate. For additional safety Freighter only works with websites that provide an SSL certificate."
},
"The website <1>{{url}}</1> does not use an SSL certificate": {
" For additional safety Freighter only works with websites that provide an SSL certificate": "The website <1>{{url}}</1> does not use an SSL certificate. For additional safety Freighter only works with websites that provide an SSL certificate."
},
"them noted to confirm you got them right": "them noted to confirm you got them right",
"this alert by going to": "this alert by going to",
"This asset has a balance": "This asset has a balance",
Expand Down
3 changes: 3 additions & 0 deletions extension/src/popup/locales/pt/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,9 @@
"The website <1>{{domain}}</1> does not use an SSL certificate": {
" For additional safety Freighter only works with websites that provide an SSL certificate": "The website <1>{{domain}}</1> does not use an SSL certificate. For additional safety Freighter only works with websites that provide an SSL certificate."
},
"The website <1>{{url}}</1> does not use an SSL certificate": {
" For additional safety Freighter only works with websites that provide an SSL certificate": "The website <1>{{url}}</1> does not use an SSL certificate. For additional safety Freighter only works with websites that provide an SSL certificate."
},
"them noted to confirm you got them right": "them noted to confirm you got them right",
"this alert by going to": "this alert by going to",
"This asset has a balance": "This asset has a balance",
Expand Down
8 changes: 4 additions & 4 deletions extension/src/popup/views/SignBlob/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export const SignBlob = () => {
);

const blob = parsedSearchParam(location.search) as BlobToSign;
const { accountToSign, domain, isDomainListedAllowed } = blob;
const { accountToSign, domain, isDomainListedAllowed, url } = blob;

const {
allAccounts,
Expand Down Expand Up @@ -72,7 +72,7 @@ export const SignBlob = () => {
);
}

if (!domain.startsWith("https") && !isExperimentalModeEnabled) {
if (!url.startsWith("https") && !isExperimentalModeEnabled) {
return (
<WarningMessage
handleCloseClick={() => window.close()}
Expand All @@ -81,8 +81,8 @@ export const SignBlob = () => {
header={t("WEBSITE CONNECTION IS NOT SECURE")}
>
<p>
<Trans domain={domain}>
The website <strong>{{ domain }}</strong> does not use an SSL
<Trans domain={url}>
The website <strong>{{ url }}</strong> does not use an SSL
certificate. For additional safety Freighter only works with
websites that provide an SSL certificate.
</Trans>
Expand Down
Loading