[FIX] incorrect query and network config for standalone #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to match standalone from the sdk
piyalbasu
approved these changes
Jan 5, 2024
piyalbasu
pushed a commit
that referenced
this pull request
Jan 25, 2024
* first pass at adding a mercury call for getBalances * adds a formatter to existing data schema in order to support backwards compat with rpc data getters * on login, check if user has account sub * movesd indexer url to shared helper, namespaces by netowrk name * refactors accoutn balance flow to include fallback to rpc in get account balances actions * cleans up actions and removes the refreshBalances flows * combines store state for all asset types * fix references to old token balance schema in asset detail * cleans up asset detail and updates test mocks * refactors internal api calls for fallback strategy server side * switches to single indexer URL, cleans up debug logs * makes logIn an async thunk, triggers account sub from logIn action * dont show soroban tokens for swaps * corrects check for soroban asset in asset detail * remove token status from history loading state * tweaks decimals check to account for falsy values * renames api back to getAccountBalances * makes setPubKey async and adds subscription to action, fixes has account check to key from key id * adds loading state to account services for switching accounts * updates backend calls to include network param, adds token balance subscription * makes isFunded non nullable, fixes import order and renames var for publicKey * adds env var for INDEXER_URL, updates actions to use it * adds check for missing token balances, to add to remove list * refactor tx submit actions to use the new indexer route * removes stray log * removes internal functions to submit transactions, replaced by call to backend * moves all uses of rpc servers to new backend routes, temp disables tx tests * removes temp unused import in tests * removes test for code that moved to backend * cleans up test, stray logs, adds mocks for token payment test * comment out unused import, temporary * fixes bug in subscribeAccount and uses correct selector for pub key in add token flow * Mercury account history (#1037) * adds token sub internal calls * splits operation flows between mercury data and rpc data for sorting and displaying operations by asset * cleans up new api path * adds token history sub when adding a token * adds network details to history queries, fixes typo in token detail response * adds fee and memo from indexer operation schema * adjust response consumption for API update * removes unused instances of soroban client * removes last uses of soroban rpc, adds token transfer simulation through backend * tweaks history entry for token mints * fixes incorrect query params, and updates custom networks identifier to match standalone from the sdk (#1077) * adds explicit checks for response types from backend calls (#1078) * updates tests and tweaks asset detail from master merge * tweaks history helper to accomodate Mercury response change (#1085) * splits dotenv so prod can use systemvars from CI (#1088) * Feature/hardware wallet interface (#1087) * make adding hardware wallets configurable * Added translations * add a readme and simplify the use of images * fix typos * rm console log
piyalbasu
added a commit
that referenced
this pull request
Jan 26, 2024
* Feature/hardware wallet interface (#1087) * make adding hardware wallets configurable * Added translations * add a readme and simplify the use of images * fix typos * rm console log * Account Balance Mercury V1 (#1035) * first pass at adding a mercury call for getBalances * adds a formatter to existing data schema in order to support backwards compat with rpc data getters * on login, check if user has account sub * movesd indexer url to shared helper, namespaces by netowrk name * refactors accoutn balance flow to include fallback to rpc in get account balances actions * cleans up actions and removes the refreshBalances flows * combines store state for all asset types * fix references to old token balance schema in asset detail * cleans up asset detail and updates test mocks * refactors internal api calls for fallback strategy server side * switches to single indexer URL, cleans up debug logs * makes logIn an async thunk, triggers account sub from logIn action * dont show soroban tokens for swaps * corrects check for soroban asset in asset detail * remove token status from history loading state * tweaks decimals check to account for falsy values * renames api back to getAccountBalances * makes setPubKey async and adds subscription to action, fixes has account check to key from key id * adds loading state to account services for switching accounts * updates backend calls to include network param, adds token balance subscription * makes isFunded non nullable, fixes import order and renames var for publicKey * adds env var for INDEXER_URL, updates actions to use it * adds check for missing token balances, to add to remove list * refactor tx submit actions to use the new indexer route * removes stray log * removes internal functions to submit transactions, replaced by call to backend * moves all uses of rpc servers to new backend routes, temp disables tx tests * removes temp unused import in tests * removes test for code that moved to backend * cleans up test, stray logs, adds mocks for token payment test * comment out unused import, temporary * fixes bug in subscribeAccount and uses correct selector for pub key in add token flow * Mercury account history (#1037) * adds token sub internal calls * splits operation flows between mercury data and rpc data for sorting and displaying operations by asset * cleans up new api path * adds token history sub when adding a token * adds network details to history queries, fixes typo in token detail response * adds fee and memo from indexer operation schema * adjust response consumption for API update * removes unused instances of soroban client * removes last uses of soroban rpc, adds token transfer simulation through backend * tweaks history entry for token mints * fixes incorrect query params, and updates custom networks identifier to match standalone from the sdk (#1077) * adds explicit checks for response types from backend calls (#1078) * updates tests and tweaks asset detail from master merge * tweaks history helper to accomodate Mercury response change (#1085) * splits dotenv so prod can use systemvars from CI (#1088) * Feature/hardware wallet interface (#1087) * make adding hardware wallets configurable * Added translations * add a readme and simplify the use of images * fix typos * rm console log * only goToReview on button click (#1090) --------- Co-authored-by: aristides <aristides.staffieri@stellar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://stellarorg.atlassian.net/browse/WAL-1228 along with stellar/freighter-backend#17
Updates custom network identifier to be
STANDALONEwhich matches the sdk value used in the backend.Corrects or adds the missing query params to pass rpc urls for custom networks.