splits logic for auth entry invocations to account for contract creation #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| invocation: InvocationArgs | undefined, | ||
| ): invocation is InvocationArgs => !!invocation; | ||
|
|
||
| function getInvocationArgs( |
There was a problem hiding this comment.
This fn has a good amount of overlap with 'buildInvocationTree', there should be the opportunity to combine these in the future but I didn't do it today in order to keep the change set as small as possible before the vote.
piyalbasu
reviewed
Feb 20, 2024
| (detail) => detail.type === "wasm", | ||
| ) as FnArgsCreateWasm[]; | ||
| const createSacs = details.filter( | ||
| (detail) => detail.type === "sac", |
There was a problem hiding this comment.
future improvement: might be nice to store these arg types in an enum for easier reuse
There was a problem hiding this comment.
makes sense, I think we can refactor this to possibly just drop all of this in favor of some tweaks to buildInvocationTree
piyalbasu
approved these changes
Feb 20, 2024
piyalbasu
added a commit
that referenced
this pull request
Feb 22, 2024
* fix error in string translation (#1125) * adds invoker auth warning in signing flow * Added translations * update variant and copy for invoker auth warning * enabling mainnet access to Soroban (#1123) * splits logic for auth entry invocations to account for contract creation (#1126) * fixes display for scvBytes in preview helper * Feature/token allowlist copy update (#1132) * legal copy updates for allowlist warnings * Added translations * match style of destination acct not found error * update account creation warning copy * Feature/token allowlist copy update (#1133) * legal copy updates for allowlist warnings * Added translations * match style of destination acct not found error * update account creation warning copy * add space * change link styling to bold instead of underline (#1134) --------- Co-authored-by: Aristides Staffieri <aristides.staffieri@stellar.org>
aristidesstaffieri
added a commit
that referenced
this pull request
Feb 26, 2024
* fix error in string translation (#1125) * adds invoker auth warning in signing flow * Added translations * update variant and copy for invoker auth warning * enabling mainnet access to Soroban (#1123) * splits logic for auth entry invocations to account for contract creation (#1126) * fixes display for scvBytes in preview helper * adds notification and handles state for API errors from account-balances * Added translations * Added translations * captures remaining api errors in sentry, adds better handler of missing token details in history item rows * fixes import order in AddToken * reverts wrong change from master merge * consolidate error case for fetching token details in add token flow * restores token details for standalone row from merge choice * Added translations --------- Co-authored-by: Piyal Basu <pbasu235@gmail.com>
piyalbasu
added a commit
that referenced
this pull request
Feb 27, 2024
* Bugfix/restore standalone balances (#1138) * fetch balances locally for standalone networks * conform token balances to the balances we get back from indexer * Sign/Submit transaction tests (#1140) * moves scValByType to helpers, adds tests for scValByType address types * adds remaining tests for scValByType * updates SignTransaction test for new tabs UI, fixes broken detail checkers * Added translations * fixes send token payment tests * removes leftover debug logs * adds fallback to local mode in account history for custom networks * restoring sign/send for standalone networks (#1141) * restoring sign/send for standalone networks * pr comment * Bugfix/fix send amount (#1142) * restoring sign/send for standalone networks * pr comment * format available send amount for tokens * Tests/add soroban token (#1143) * add tests for verified tokens * align verification message * adds metric events for review auth and sign tx * tweaks mock balances to account for decimals in input * reorganize imports * Improves API error handling & states (#1137) * fix error in string translation (#1125) * adds invoker auth warning in signing flow * Added translations * update variant and copy for invoker auth warning * enabling mainnet access to Soroban (#1123) * splits logic for auth entry invocations to account for contract creation (#1126) * fixes display for scvBytes in preview helper * adds notification and handles state for API errors from account-balances * Added translations * Added translations * captures remaining api errors in sentry, adds better handler of missing token details in history item rows * fixes import order in AddToken * reverts wrong change from master merge * consolidate error case for fetching token details in add token flow * restores token details for standalone row from merge choice * Added translations --------- Co-authored-by: Piyal Basu <pbasu235@gmail.com> * add lighter weight getpublickey with docs (#1146) * add lighter weight getpublickey with docs * add request access to playground * Feature/disable soroban based on health (#1147) * check rpc health to disable soroban; fix token balance in choose asset menu * Added translations * check for rpc health and feature flags when experimental mode is changed * Fix/restore dropped merge diff (#1148) * restores lost changes from history item merge * Added translations * fixes scValByType test for bytes * fix manageAssets test (#1149) * fixes router loading window by adding full height (#1151) * update broken link and update freighter-api dep (#1150) * use the network passphrase from the passed xdr to properly figure out… (#1152) * use the network passphrase from the passed xdr to properly figure out what networkt he tx was built for * fix broken tests --------- Co-authored-by: aristides <aristides.staffieri@stellar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes auth entry invocation tree renderer to account for contract creation