[WIP] Feature/auto horizon error #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1 @@ | |||
| {} | |||
| response = await res.json(); | ||
| } catch (e) { | ||
| captureException( | ||
| `Failed to load feature flag for Soroban mainnet - ${JSON.stringify(e)}`, |
There was a problem hiding this comment.
Nit but feature flags are not per network right now
There was a problem hiding this comment.
Oh good catch - bad copy/paste job
piyalbasu
commented
Mar 15, 2024
| @@ -455,7 +455,6 @@ export const getAccountIndexerBalances = async ( | |||
| if ("error" in data && (data?.error?.horizon || data?.error?.soroban)) { | |||
| const _err = JSON.stringify(data.error); | |||
| captureException(`Failed to fetch account balances - ${_err}`); | |||
| throw new Error(_err); | |||
There was a problem hiding this comment.
throw an error here leads to the redux thunk rejecting - which just leads to the generic Failed to fetch account balances error. If we don't throw, we can show the user a Horizon specific error
piyalbasu
commented
Mar 15, 2024
| @@ -309,7 +309,7 @@ export const Account = () => { | |||
| /> | |||
| </div> | |||
| )} | |||
| {!isFunded && !hasError && ( | |||
| {!isFunded && !hasError && !error?.horizon && ( | |||
There was a problem hiding this comment.
don't show the unfunded message if we have a horizon message bc we're not sure if you're funded or not
piyalbasu
added a commit
that referenced
this pull request
Mar 18, 2024
* handles not ok cases that dont fall through to catch block, resets account sub storage * removes the rpc urls passed to the backend, no longer needed after standalone move back to client side * upgrades webpack and babel-loader * regen yarn lock file * pins redux toolkit version * upgrades typescript, eslint and plugins * use correct eslint version * restore awaits on redux dispatches * upgrades react and rect-dom to >=18 * updates test to waitFor dom nodes, react 18 batching updates * upgrades stellar-sdk to 11.2.2 * Bugfix/allowlist native contract (#1179) * add native contract to verified assets list * do not show verification for XLM * fix linting errors * fix linting issue * [Soroban] getTokenInvocationArgs amount should be bigint or number (#1181) * [FEATURE] Token transfer summary in auth entry review (#1182) * adds loading state for token details in token summary * adds soroban token icon in token summary * adds sender to transfer summary * restore async message listener (#1183) * clean up UI for showing "destination acct doesn't exist" warning (#1184) * clean up UI for showing "destination acct doesn't exist" warning * cleanup import order * formats token amounts in transfer summary, removes token transfer constraint in history items for soroban ops * adds fallback to raw value with warning when unable to fetch token details * flips title boolean in NetworkForm to show correct title * adds layout styles to form container to avoid button overflow in footer * namespace FormContainer under AddAsset * handle horizon error result codes (#1188) * tweaks loading state in Account in order to avoid flicker between account changes * plumbs setLoading through to account header in order to retain loading state when switchin accounts * remvoes debug logs * trying to clean up Amplitude Sentry errors a bit more (#1189) * adds missing loading state for asset detail and transaction detail, fixes redundant title in error message * adds asset error check in loading state * labels status on send error when status is available * tweaks op_no_trust error notification to not repeat title in body * Added translations * adds send option for soroban token from asset detail (#1193) * [WIP] Feature/auto horizon error (#1195) * first pass at adding horizon and generic notifications * Added translations * fix translations * fix sentry errors * update error type * fix error * show horizon error msg * Bugfix/user notification typo (#1196) * fix typo * Added translations * fix auto-scrolling in add trustlines views (#1199) --------- Co-authored-by: Aristides Staffieri <aristides.staffieri@stellar.org> Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.