Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix auto-scrolling in add trustlines views #1199

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix auto-scrolling in add trustlines views #1199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extension/src/popup/components/manageAssets/AddAsset/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export const AddAsset = () => {
<Formik initialValues={initialValues} onSubmit={handleSubmit}>
{({ dirty, errors, isSubmitting, isValid, touched }) => (
<Form className="AddAsset__FormContainer">
<React.Fragment>
<View>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because this is a UI bug, not a DOM issue, we'll need to build an e2e test for this view and then test this using Playwright. I'll be looking at this as part of our Manifest v3 testing

<SubviewHeader title={t("Add Another Asset")} />
<View.Content>
<FormRows>
Expand Down Expand Up @@ -138,7 +138,7 @@ export const AddAsset = () => {
{t("Search")}
</Button>
</View.Footer>
</React.Fragment>
</View>
</Form>
)}
</Formik>
Expand Down
2 changes: 1 addition & 1 deletion extension/src/popup/components/manageAssets/AddAsset/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
:root {
--AddAsset--results-height: 22.9rem;
--AddAsset--results-height: 23.2rem;
--AddAsset--title-height: 3rem;
}

Expand Down
4 changes: 2 additions & 2 deletions extension/src/popup/components/manageAssets/SearchAsset/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export const SearchAsset = () => {
setHasNoResults(false);
}}
>
<React.Fragment>
<View>
<SubviewHeader title={t("Choose Asset")} />
<View.Content>
<FormRows>
Expand Down Expand Up @@ -205,7 +205,7 @@ export const SearchAsset = () => {
) : null}
</FormRows>
</View.Content>
</React.Fragment>
</View>
</Form>
)}
</Formik>
Expand Down
Loading