show token details for standalone transfer summary #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyalbasu
commented
Mar 20, 2024
| @@ -332,15 +336,53 @@ const AuthDetail = ({ | |||
| // eslint-disable-next-line | |||
| for (const transfer of transfers) { | |||
| try { | |||
| // eslint-disable-next-line | |||
| const response = await fetch(tokenDetailsUrl(transfer.contractId)); | |||
| if (isCustomNetwork(networkDetails)) { | |||
There was a problem hiding this comment.
on standalone networks, use sorobanClient.server to fetch details rather than the BE
piyalbasu
commented
Mar 20, 2024
|
|
||
| setTokenDetails(_tokenDetails); | ||
| } else { | ||
| // eslint-disable-next-line |
There was a problem hiding this comment.
the else case is unchanged; it's just what we used to do by default before
piyalbasu
commented
Mar 20, 2024
| @@ -218,7 +221,7 @@ type TokenDetailMap = Record<string, TokenDetails>; | |||
|
|
|||
| const TransferSummary = ({ | |||
| transfer, | |||
| tokenDetails, | |||
| tokenDetails = { name: "", symbol: "", decimals: 0 }, | |||
There was a problem hiding this comment.
adding sane defaults in case this is ever undefined
quietbits
approved these changes
Mar 20, 2024
| @@ -228,7 +231,7 @@ const TransferSummary = ({ | |||
| }; | |||
| tokenDetails: TokenDetails; | |||
| }) => { | |||
| const hasTokenDetails = tokenDetails.symbol && tokenDetails.decimals; | |||
| const hasTokenDetails = tokenDetails?.symbol && tokenDetails?.decimals; | |||
There was a problem hiding this comment.
tokenDetails shouldn't be undefined with the default value provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.