[CHORE] Refactor standalone workflows #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs to shared namespace
| @@ -3,5 +3,5 @@ | |||
| "compilerOptions": { | |||
| "baseUrl": "." | |||
| }, | |||
| "include": ["."] | |||
| "include": [".", "../helpers/stellar.ts"] | |||
There was a problem hiding this comment.
Looks like this was auto-added because I include this helper in the api layer usage now.
…lign these states
| @@ -44,6 +44,8 @@ $loader-light-color: #444961; | |||
| } | |||
|
|
|||
| &--error { | |||
| width: 32px; | |||
There was a problem hiding this comment.
Unrelated but I snuck these in here since these 10liners fix the loading state for assets on account details.
piyalbasu
reviewed
Mar 26, 2024
@shared/api/internal.ts
Outdated
| }); | ||
| }; | ||
|
|
||
| export const getIndexerTokenDetails = async ({ |
There was a problem hiding this comment.
should this be called getTokenDetails because it handles both the standalone/custom case and the indexer case?
There was a problem hiding this comment.
yeah for sure it should 😄 , done in 797a2c5
piyalbasu
approved these changes
Mar 26, 2024
…te in review auth and tweaks height setter in SlideUpModal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds getTokenDetails, and replaces all inline calls to get token details
Makes getAccountHistory, to abstract over standalone mode vs indexer history
Moves all data related uses of
isCustomNetworkinto the data layerMoves uses of Soroban server/tx builder into standalone workflows
Removes SorobanContext, replaces uses with helpers in standalone workflows
Why
Cleans up logic after the move to client side standalone mode. Soroban server and tx builder is only needed in standalone mode now, but we still used old logic and constructs with the assumptions that they were needed in all cases.