Feature/check multiple tokenlist #1221
Conversation
| {t("Learn more")} | ||
| </Link> | ||
| <div className="TokenWarning__flag__content"> | ||
| {t("This is a relatively new asset")} |
There was a problem hiding this comment.
This "relatively new asset" is hardcoded for now (as all the assets are "relatively new" 😄 ). I'm looking into how we can actually figure out if an asset is now
There was a problem hiding this comment.
We could index for new token deployments in the future but yeah not sure what else we could do right now.
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@stellar-asset-lists/sdk@1.0.0 |
| return true; | ||
| promiseRes.forEach((r) => { | ||
| if (r.status === "fulfilled") { | ||
| const list = r.value?.tokens ? r.value?.tokens : r.value?.assets; |
There was a problem hiding this comment.
in the future, these should all adhere to the SEP0042 spec where the key will be called tokens. Adding this check for now while I wait for Soroswap to fix this on their end
|
Also, something interesting to note is that when adding a SAC, the indexer is coming back with 2 separate balances: 1 for the classic Horizon balance and 1 for the contract balance. I've created a ticket here: https://stellarorg.atlassian.net/browse/WAL-1418 |
Hmm yeah I guess really we shouldn't let SACs be added through the Soroban token flows since they are already represented in the wallet through the classic side. The SAC stores the |
Bruno's working on a spec for the SAC experience. The idea is basically if you add a SAC contract ID, it'll just add the trustline for it and we'll just use Horizon for balance & payment. If you already have the trustline, it likely just won't do anything |
* before we close the sign transaction window, complete metrics upload (#1209) * Better UX for contract IDs (#1122) * adds new component TruncateMiddle, handles dynamic truncation based on parent width * adds font prop and tweaks operation pair to allow for width measuring * tweaks container styles, adds use in keyval list * adds copy to all contract IDs and keys from outside sources * removes unused ref from previosu tries * adds tests for truncateString helper * fixes tests after dom changes on contract IDs * adds copy value component, replaces inline copy instances. Uses boolean namign pattern. Only hides generic domain icon when domain is not present in asset detail * fixes lint warnings * uses truncated display value in KeyVal CopyValues * Feature/multiple allow list (#1210) * add migration for assetslist; create UI for displaying assets lists * add translations * adds internal getTokenDetails call, moves server and tx builder helpers to shared namespace * replaces all inline calls to get token details with internal helper call * replaces some instances of sorobanClient from context * removes remaining uses of soroban client from context, remove soroban context * adds soroban rpc not supported error * adds sizes to error and loading asset icons to fix layout shift and align these states * renames getIndexerTokenDetails to getTokenDetails, tweaks loading state in review auth and tweaks height setter in SlideUpModal * Feature/check multiple tokenlist (#1221) * first pass at adding multiple asset lists * add verification badge * add asset notifcation tooltip * Added translations * rm consoles * update yarn * reset debounce param * use getTokenDetails * fix tests * fixes keyboard navigation for onboarding - create new wallet flow * adds key handling for recover account form in onboarding * adds native-like-outline mixin * Feature/modify asset list (#1224) * add ability to edit/delete asset lists * Added translations * break if unable to load schema * add comments * make sure to check for isEnabled when verifying (#1225) * make sure to check for isEnabled when verifying * don't assign the func outside of the conditional * Feature/delete asset list modal (#1226) * add delete asset list modal * Added translations * add view padding offset * Bugfix/copy fix token list (#1227) * copy fix for asset select token list verification * Added translations * fix submit error (#1228) * default to selected network if network is verifiable (#1229) * default to selected network if network is verifiable * remove extraneous check * Feature/redesign settings (#1232) * add settings icons using svgr * Added translations * fix jest tests * rollback ledger testing * rm extra spaces * Validate asset list on every fetch (#1234) * Added translations * rm console logs * asset list UI cleanup (#1235) * break once we found the contract in asset list (#1237) * add a test add token asset list verification (#1236) * address design QA (#1238) * address design QA * dispatch click event for createPortal button * Bugfix/product qa 5.18.0 (#1239) * don't reset isEnabled state; better error messaging * add shadows to scrollable area * Bugfix/design fixes 5.18.0 (#1240) * add enabled/disabled sections and fix submit error * Added translations --------- Co-authored-by: aristides <aristides.staffieri@stellar.org>
Screen.Recording.2024-03-29.at.5.43.15.PM.mov
This covers 3 scenarios: