-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/check multiple tokenlist #1221
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a33d7dc
first pass at adding multiple asset lists
piyalbasu cc98207
add verification badge
piyalbasu 08efaf2
add asset notifcation tooltip
piyalbasu f0f1adb
Add token warning
piyalbasu 49b348e
Added translations
piyalbasu 65c6f5f
rm consoles
piyalbasu adc4549
update yarn
piyalbasu 1f01a17
Merge branch 'release/5.18.0' into feature/check-multiple-tokenlist
piyalbasu 1cd9eac
reset debounce param
piyalbasu acafccb
use getTokenDetails
piyalbasu 86bd4c1
fix tests
piyalbasu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
27 changes: 27 additions & 0 deletions
27
extension/src/popup/components/AssetNotification/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import React from "react"; | ||
import { useTranslation } from "react-i18next"; | ||
import { Tooltip, Icon } from "@stellar/design-system"; | ||
|
||
import "./styles.scss"; | ||
|
||
export const AssetNotifcation = ({ isVerified }: { isVerified: boolean }) => { | ||
const { t } = useTranslation(); | ||
|
||
return ( | ||
<div className="AssetNotification" data-testid="asset-notification"> | ||
{isVerified ? t("On your lists") : t("Not on your lists")} | ||
<Tooltip | ||
placement="right" | ||
triggerEl={ | ||
<button className="AssetNotification__button"> | ||
<Icon.Info className="AssetNotification__info" /> | ||
</button> | ||
} | ||
> | ||
{t( | ||
"Freighter uses asset lists to check assets you interact with. You can define your own assets lists in Settings.", | ||
)} | ||
</Tooltip> | ||
</div> | ||
); | ||
}; |
24 changes: 24 additions & 0 deletions
24
extension/src/popup/components/AssetNotification/styles.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
.AssetNotification { | ||
align-items: center; | ||
color: var(--color-gray-70); | ||
display: flex; | ||
font-size: 0.875rem; | ||
font-weight: var(--font-weight-medium); | ||
gap: 0.25rem; | ||
line-height: 1.25rem; | ||
margin-bottom: 1rem; | ||
|
||
&__button { | ||
border: none; | ||
background: none; | ||
display: flex; | ||
text-decoration: none; | ||
cursor: pointer; | ||
padding: 0; | ||
} | ||
|
||
&__info { | ||
height: 0.875rem; | ||
width: 0.875rem; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "relatively new asset" is hardcoded for now (as all the assets are "relatively new" 😄 ). I'm looking into how we can actually figure out if an asset is now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could index for new token deployments in the future but yeah not sure what else we could do right now.