Feature/improve api error states #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyalbasu
reviewed
Apr 11, 2024
| allAccounts: Account[]; | ||
| currentAccountName: string; | ||
| publicKey: string; | ||
| setLoading: (isLoading: boolean) => void; | ||
| } | ||
|
|
||
| export const AccountHeader = ({ | ||
| // accountDropDownRef, |
There was a problem hiding this comment.
is this just an unused prop now? should we get rid of it?
There was a problem hiding this comment.
yup it is, at some point it went from an unused prop to a commented out one so I deleted it.
piyalbasu
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Disables send link when account balances are unavailable
Adds error state for account history, with notification
Why
Currently if we fail to get account balances, users can still attempt to go through the payment flow even though it won't work
Currently we display an empty history page with no error message if we fail to get account history