address design QA #1238
Merged
address design QA #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristidesstaffieri
approved these changes
Apr 16, 2024
piyalbasu
added a commit
that referenced
this pull request
Apr 23, 2024
* before we close the sign transaction window, complete metrics upload (#1209) * Better UX for contract IDs (#1122) * adds new component TruncateMiddle, handles dynamic truncation based on parent width * adds font prop and tweaks operation pair to allow for width measuring * tweaks container styles, adds use in keyval list * adds copy to all contract IDs and keys from outside sources * removes unused ref from previosu tries * adds tests for truncateString helper * fixes tests after dom changes on contract IDs * adds copy value component, replaces inline copy instances. Uses boolean namign pattern. Only hides generic domain icon when domain is not present in asset detail * fixes lint warnings * uses truncated display value in KeyVal CopyValues * Feature/multiple allow list (#1210) * add migration for assetslist; create UI for displaying assets lists * add translations * adds internal getTokenDetails call, moves server and tx builder helpers to shared namespace * replaces all inline calls to get token details with internal helper call * replaces some instances of sorobanClient from context * removes remaining uses of soroban client from context, remove soroban context * adds soroban rpc not supported error * adds sizes to error and loading asset icons to fix layout shift and align these states * renames getIndexerTokenDetails to getTokenDetails, tweaks loading state in review auth and tweaks height setter in SlideUpModal * Feature/check multiple tokenlist (#1221) * first pass at adding multiple asset lists * add verification badge * add asset notifcation tooltip * Added translations * rm consoles * update yarn * reset debounce param * use getTokenDetails * fix tests * fixes keyboard navigation for onboarding - create new wallet flow * adds key handling for recover account form in onboarding * adds native-like-outline mixin * Feature/modify asset list (#1224) * add ability to edit/delete asset lists * Added translations * break if unable to load schema * add comments * make sure to check for isEnabled when verifying (#1225) * make sure to check for isEnabled when verifying * don't assign the func outside of the conditional * Feature/delete asset list modal (#1226) * add delete asset list modal * Added translations * add view padding offset * Bugfix/copy fix token list (#1227) * copy fix for asset select token list verification * Added translations * fix submit error (#1228) * default to selected network if network is verifiable (#1229) * default to selected network if network is verifiable * remove extraneous check * Feature/redesign settings (#1232) * add settings icons using svgr * Added translations * fix jest tests * rollback ledger testing * rm extra spaces * Validate asset list on every fetch (#1234) * Added translations * rm console logs * asset list UI cleanup (#1235) * break once we found the contract in asset list (#1237) * add a test add token asset list verification (#1236) * address design QA (#1238) * address design QA * dispatch click event for createPortal button * Bugfix/product qa 5.18.0 (#1239) * don't reset isEnabled state; better error messaging * add shadows to scrollable area * Bugfix/design fixes 5.18.0 (#1240) * add enabled/disabled sections and fix submit error * Added translations --------- Co-authored-by: aristides <aristides.staffieri@stellar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.