enable sending a token or a SAC payment to a C address #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyalbasu
commented
Aug 16, 2024
| @@ -46,7 +46,7 @@ export const ChooseAsset = ({ balances }: ChooseAssetProps) => { | |||
| const isSwap = useIsSwap(); | |||
| const isSoroswapEnabled = useIsSoroswapEnabled(); | |||
|
|
|||
| const managingAssets = assetSelect.type === AssetSelectType.MANAGE; | |||
| const isManagingAssets = assetSelect.type === AssetSelectType.MANAGE; | |||
There was a problem hiding this comment.
This is just a var name issue that was bugging me , so fixing it here
piyalbasu
commented
Aug 16, 2024
| @@ -85,6 +88,24 @@ export const Settings = ({ | |||
| // dont show memo for regular sends to Muxed, or for swaps | |||
| const showMemo = !isSwap && !isMuxedAccount(destination); | |||
| const showSlippage = (isPathPayment || isSwap) && !isSoroswap; | |||
| const isSendSacToContract = | |||
| isContractId(destination) && | |||
| !isContractId(getAssetFromCanonical(asset).issuer); | |||
There was a problem hiding this comment.
The logic here is basically:
If you're sending to a C address, but you're trying to send a classic asset, grab the C address of the SAC
piyalbasu
commented
Aug 16, 2024
| @@ -109,8 +130,10 @@ export const Settings = ({ | |||
| return; | |||
| } | |||
|
|
|||
| if (isToken) { | |||
| const assetAddress = asset.split(":")[1]; | |||
| if (isToken || isSendSacToContract) { | |||
There was a problem hiding this comment.
Sending a token to a C address generally worked "out of the box" once I allowed a user to enter a C address as a destination 🎉
piyalbasu
commented
Aug 16, 2024
| @@ -106,7 +107,7 @@ export const SendTo = ({ previous }: { previous: ROUTES }) => { | |||
| ); | |||
|
|
|||
| const [recentAddresses, setRecentAddresses] = useState<string[]>([]); | |||
| const [validatedPubKey, setValidatedPubKey] = useState(""); | |||
| const [validatedAddress, setValidatedAddress] = useState(""); | |||
There was a problem hiding this comment.
var rename to reflect we can send to either a public key or a C address
aristidesstaffieri
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1414
Allowing user to send a payment to a C address using either a token or a SAC