fix types #1435
Merged
fix types #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyalbasu
commented
Aug 21, 2024
| @@ -28,7 +28,9 @@ export const SESSION_STORAGE_ENABLED = true; | |||
|
|
|||
| export const normalizeMigratedData = async () => { | |||
There was a problem hiding this comment.
this is a helper that really shouldn't be running anymore. This was used to migrate data from localStorage to chrome.storage. Apparently there was an error in the code here when we switched over to v3, but we never noticed because if a user is on v3, this function returns early on ln 39
aristidesstaffieri
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.