-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate invoke host function inputs from JSON Spec #1250
Conversation
@@ -22,13 +22,17 @@ | |||
"@creit.tech/stellar-wallets-kit": "^1.2.5", | |||
"@ledgerhq/hw-app-str": "^7.0.4", | |||
"@ledgerhq/hw-transport-webusb": "^6.29.4", | |||
"@rjsf/core": "^5.24.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
included for feature-invoke-host-function
branch so that we can use it as an example and test our implementation
Preview is available here: |
<Button | ||
variant="secondary" | ||
size="md" | ||
onClick={() => {}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its onClick to add implementation will be added in the next PR
Preview is available here: |
case "I64": | ||
case "I128": | ||
case "I256": | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious: why are we not rendering these types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I was going to create a component that allows both positive and negative number. I'll do that next!
Co-authored-by: Iveta <quietbits@users.noreply.github.com>
Preview is available here: |
Summary/This PR includes::
react-jsonschema-form
library because the library is huge and includes many stuff that we do not need (components, ex). I confirmed with Willem that our spec schema is simple - there is no circular or external reference so we should be able to implement our own. But the library is included infeature-invoke-host-function
so that we could test our implementation against it--
yarn.lock
file should include less changes once we remove this libraryThis PR does not include:
Add {label}
should apper; however, but it's not adding a new item yetminLength
andmaxLength
limit fromspec