Bug 1076 conversion error flattening 2 #1218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graydon
force-pushed
the
bug-1076-conversion-error-flattening-2
branch
from
643e312 to
0d586a0
Compare
|
decided against this one for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to PR #1216 where we plumb the
env::Errorcode all the way up to the surface of the SDK's UI.I don't feel strongly about doing this or the other one, they both seem to work, it's a question of UI complexity. Neither approach suffers the problem that motivated this change at the env level, where we went from
ErrortoConversionErrorand then back toErrorand thereby produced misleadingErrorcodes.