Move the Env testutil internal types into a single type #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
approved these changes
Mar 1, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
### What Add option to disable test snapshots on Env ### Why In some situations a developer needs to disable test snapshots. The default is that they are always on, in the interest of giving all developers a way to identify unexpected and otherwise untested for changed behavior during SDK upgrades, no protocol releases, or their own developer lifecycle. Close #1225 ### Merging This change is dependent on the following change merging first, and will be kept in draft state until then: - #1234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Move the Env testutil internal types into a single type.
Why
The Env when used with testutils enabled has a few internal fields. Those internal fields are copied around between MaybeEnv and Env, and because they're individual fields there's repetitive calls on each field, and repetitive compiler attributes. It's painful each time we add a new one to remember and find all the places that need adding. Using a single type groups all those repetitive actions so we don't need to keep repeating them for new types to add.
I'm about to add another field.