Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: guess returns exit code 0 with empty stdout if no matches found #413

Open
Ifropc opened this issue Feb 21, 2025 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@Ifropc
Copy link
Contributor

Ifropc commented Feb 21, 2025

If no matches are found (given a valid base64 string but an invalid XDR), guess command prints nothing and returns code 0, which might be confusing to the user.

We can return an error if no matches are found, or stderr a warning with code 0

(Personally I prefer the second approach)

@Ifropc Ifropc added the bug Something isn't working label Feb 21, 2025
@Ifropc Ifropc self-assigned this Feb 21, 2025
@Ifropc
Copy link
Contributor Author

Ifropc commented Feb 25, 2025

@leighmcculloch would be happy to hear your thought on that, should be a small change either way 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant