Skip to content

Commit

Permalink
[SDP-1022] Hotfix: update Vibrant Assist's client_domain (#126)
Browse files Browse the repository at this point in the history
### What

Update client_domain on Vibrant Assist from api.vibrantapp.com to vibrantapp.com.

### Why

It was incorrect.
  • Loading branch information
marcelosalloum authored Dec 15, 2023
1 parent d208a08 commit 67c4af6
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 11 deletions.
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

> Place unreleased changes here.
## [1.0.1](https://github.com/stellar/stellar-disbursement-platform-backend/compare/1.0.0...1.0.1)

### Changed

- Update log message for better debugging. [#125](https://github.com/stellar/stellar-disbursement-platform-backend/pull/125)

### Fixed

- Fix client_domain from the Viobrant Assist wallet. [#126](https://github.com/stellar/stellar-disbursement-platform-backend/pull/126)

## [1.0.0](https://github.com/stellar/stellar-disbursement-platform-backend/compare/1.0.0-rc2...1.0.0)

### Added
Expand Down
4 changes: 2 additions & 2 deletions cmd/db_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ func Test_DatabaseCommand_db_setup_for_network(t *testing.T) {
// assert.Equal(t, "https://www.beansapp.com/disbursements/registration?redirect=true", wallets[0].DeepLinkSchema)
assert.Equal(t, "Vibrant Assist", wallets[0].Name)
assert.Equal(t, "https://vibrantapp.com/vibrant-assist", wallets[0].Homepage)
assert.Equal(t, "api.vibrantapp.com", wallets[0].SEP10ClientDomain)
assert.Equal(t, "vibrantapp.com", wallets[0].SEP10ClientDomain)
assert.Equal(t, "https://vibrantapp.com/sdp", wallets[0].DeepLinkSchema)

assert.Equal(t, "Vibrant Assist RC", wallets[1].Name)
Expand All @@ -235,7 +235,7 @@ func Test_DatabaseCommand_db_setup_for_network(t *testing.T) {
"Name: Vibrant Assist",
"Homepage: https://vibrantapp.com/vibrant-assist",
"Deep Link Schema: https://vibrantapp.com/sdp",
"SEP-10 Client Domain: api.vibrantapp.com",
"SEP-10 Client Domain: vibrantapp.com",
}

logs := buf.String()
Expand Down
2 changes: 1 addition & 1 deletion helmchart/sdp/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: stellar-disbursement-platform
description: A Helm chart for the Stellar Disbursement Platform Backend (A.K.A. `sdp`)
version: 0.9.3
appVersion: "1.0.0"
appVersion: "1.0.1"
type: application
maintainers:
- name: Stellar Development Foundation
Expand Down
12 changes: 6 additions & 6 deletions internal/services/setup_wallets_for_network_service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func Test_SetupWalletsForProperNetwork(t *testing.T) {
"Name: Vibrant Assist",
"Homepage: https://vibrantapp.com/vibrant-assist",
"Deep Link Schema: https://vibrantapp.com/sdp",
"SEP-10 Client Domain: api.vibrantapp.com",
"SEP-10 Client Domain: vibrantapp.com",
}

logs := buf.String()
Expand Down Expand Up @@ -89,7 +89,7 @@ func Test_SetupWalletsForProperNetwork(t *testing.T) {
Name: "Vibrant Assist",
Homepage: "https://vibrantapp.com/vibrant-assist",
DeepLinkSchema: "https://aidpubnet.netlify.app",
SEP10ClientDomain: "api.vibrantapp.com",
SEP10ClientDomain: "vibrantapp.com",
},
{
Name: "BOSS Money",
Expand Down Expand Up @@ -118,7 +118,7 @@ func Test_SetupWalletsForProperNetwork(t *testing.T) {

assert.Equal(t, "Vibrant Assist", wallets[1].Name)
assert.Equal(t, "https://vibrantapp.com/vibrant-assist", wallets[1].Homepage)
assert.Equal(t, "api.vibrantapp.com", wallets[1].SEP10ClientDomain)
assert.Equal(t, "vibrantapp.com", wallets[1].SEP10ClientDomain)
assert.Equal(t, "https://aidpubnet.netlify.app", wallets[1].DeepLinkSchema)

expectedLogs := []string{
Expand All @@ -130,7 +130,7 @@ func Test_SetupWalletsForProperNetwork(t *testing.T) {
"Name: Vibrant Assist",
"Homepage: https://vibrantapp.com/vibrant-assist",
"Deep Link Schema: https://aidpubnet.netlify.app",
"SEP-10 Client Domain: api.vibrantapp.com",
"SEP-10 Client Domain: vibrantapp.com",
}

logs := buf.String()
Expand All @@ -152,7 +152,7 @@ func Test_SetupWalletsForProperNetwork(t *testing.T) {
Name: "Vibrant Assist",
Homepage: "https://vibrantapp.com/vibrant-assist",
DeepLinkSchema: "https://aidpubnet.netlify.app",
SEP10ClientDomain: "api.vibrantapp.com",
SEP10ClientDomain: "vibrantapp.com",
Assets: []data.Asset{
{
Code: "USDC",
Expand Down Expand Up @@ -241,7 +241,7 @@ func Test_SetupWalletsForProperNetwork(t *testing.T) {
"Name: Vibrant Assist",
"Homepage: https://vibrantapp.com/vibrant-assist",
"Deep Link Schema: https://aidpubnet.netlify.app",
"SEP-10 Client Domain: api.vibrantapp.com",
"SEP-10 Client Domain: vibrantapp.com",
"Assets:",
"* USDC - GBBD47IF6LWK7P7MDEVSCWR7DPUWV3NY3DTQEVFL4NAT4AQH3ZLLFLA5",
}
Expand Down
2 changes: 1 addition & 1 deletion internal/services/wallets/wallets_pubnet.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ var PubnetWallets = []data.Wallet{
Name: "Vibrant Assist",
Homepage: "https://vibrantapp.com/vibrant-assist",
DeepLinkSchema: "https://vibrantapp.com/sdp",
SEP10ClientDomain: "api.vibrantapp.com",
SEP10ClientDomain: "vibrantapp.com",
Assets: []data.Asset{
{
Code: "USDC",
Expand Down
2 changes: 1 addition & 1 deletion main.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (

// Version is the official version of this application. Whenever it's changed
// here, it also needs to be updated at the `helmchart/Chart.yaml#appVersion“.
const Version = "1.0.0"
const Version = "1.0.1"

// GitCommit is populated at build time by
// go build -ldflags "-X main.GitCommit=$GIT_COMMIT"
Expand Down

0 comments on commit 67c4af6

Please sign in to comment.