From 67c4af63f52b2e27cfc07b10b8551a54eee5bd1b Mon Sep 17 00:00:00 2001 From: Marcelo Salloum dos Santos Date: Thu, 14 Dec 2023 21:19:26 -0800 Subject: [PATCH] [SDP-1022] Hotfix: update Vibrant Assist's `client_domain` (#126) ### What Update client_domain on Vibrant Assist from api.vibrantapp.com to vibrantapp.com. ### Why It was incorrect. --- CHANGELOG.md | 10 ++++++++++ cmd/db_test.go | 4 ++-- helmchart/sdp/Chart.yaml | 2 +- .../setup_wallets_for_network_service_test.go | 12 ++++++------ internal/services/wallets/wallets_pubnet.go | 2 +- main.go | 2 +- 6 files changed, 21 insertions(+), 11 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7d285f99e..a242ad92a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,16 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). > Place unreleased changes here. +## [1.0.1](https://github.com/stellar/stellar-disbursement-platform-backend/compare/1.0.0...1.0.1) + +### Changed + +- Update log message for better debugging. [#125](https://github.com/stellar/stellar-disbursement-platform-backend/pull/125) + +### Fixed + +- Fix client_domain from the Viobrant Assist wallet. [#126](https://github.com/stellar/stellar-disbursement-platform-backend/pull/126) + ## [1.0.0](https://github.com/stellar/stellar-disbursement-platform-backend/compare/1.0.0-rc2...1.0.0) ### Added diff --git a/cmd/db_test.go b/cmd/db_test.go index 24d084491..9ef081896 100644 --- a/cmd/db_test.go +++ b/cmd/db_test.go @@ -217,7 +217,7 @@ func Test_DatabaseCommand_db_setup_for_network(t *testing.T) { // assert.Equal(t, "https://www.beansapp.com/disbursements/registration?redirect=true", wallets[0].DeepLinkSchema) assert.Equal(t, "Vibrant Assist", wallets[0].Name) assert.Equal(t, "https://vibrantapp.com/vibrant-assist", wallets[0].Homepage) - assert.Equal(t, "api.vibrantapp.com", wallets[0].SEP10ClientDomain) + assert.Equal(t, "vibrantapp.com", wallets[0].SEP10ClientDomain) assert.Equal(t, "https://vibrantapp.com/sdp", wallets[0].DeepLinkSchema) assert.Equal(t, "Vibrant Assist RC", wallets[1].Name) @@ -235,7 +235,7 @@ func Test_DatabaseCommand_db_setup_for_network(t *testing.T) { "Name: Vibrant Assist", "Homepage: https://vibrantapp.com/vibrant-assist", "Deep Link Schema: https://vibrantapp.com/sdp", - "SEP-10 Client Domain: api.vibrantapp.com", + "SEP-10 Client Domain: vibrantapp.com", } logs := buf.String() diff --git a/helmchart/sdp/Chart.yaml b/helmchart/sdp/Chart.yaml index 30eed34ec..4fb5d9ffe 100644 --- a/helmchart/sdp/Chart.yaml +++ b/helmchart/sdp/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: stellar-disbursement-platform description: A Helm chart for the Stellar Disbursement Platform Backend (A.K.A. `sdp`) version: 0.9.3 -appVersion: "1.0.0" +appVersion: "1.0.1" type: application maintainers: - name: Stellar Development Foundation diff --git a/internal/services/setup_wallets_for_network_service_test.go b/internal/services/setup_wallets_for_network_service_test.go index 708a51916..f8a7c441a 100644 --- a/internal/services/setup_wallets_for_network_service_test.go +++ b/internal/services/setup_wallets_for_network_service_test.go @@ -60,7 +60,7 @@ func Test_SetupWalletsForProperNetwork(t *testing.T) { "Name: Vibrant Assist", "Homepage: https://vibrantapp.com/vibrant-assist", "Deep Link Schema: https://vibrantapp.com/sdp", - "SEP-10 Client Domain: api.vibrantapp.com", + "SEP-10 Client Domain: vibrantapp.com", } logs := buf.String() @@ -89,7 +89,7 @@ func Test_SetupWalletsForProperNetwork(t *testing.T) { Name: "Vibrant Assist", Homepage: "https://vibrantapp.com/vibrant-assist", DeepLinkSchema: "https://aidpubnet.netlify.app", - SEP10ClientDomain: "api.vibrantapp.com", + SEP10ClientDomain: "vibrantapp.com", }, { Name: "BOSS Money", @@ -118,7 +118,7 @@ func Test_SetupWalletsForProperNetwork(t *testing.T) { assert.Equal(t, "Vibrant Assist", wallets[1].Name) assert.Equal(t, "https://vibrantapp.com/vibrant-assist", wallets[1].Homepage) - assert.Equal(t, "api.vibrantapp.com", wallets[1].SEP10ClientDomain) + assert.Equal(t, "vibrantapp.com", wallets[1].SEP10ClientDomain) assert.Equal(t, "https://aidpubnet.netlify.app", wallets[1].DeepLinkSchema) expectedLogs := []string{ @@ -130,7 +130,7 @@ func Test_SetupWalletsForProperNetwork(t *testing.T) { "Name: Vibrant Assist", "Homepage: https://vibrantapp.com/vibrant-assist", "Deep Link Schema: https://aidpubnet.netlify.app", - "SEP-10 Client Domain: api.vibrantapp.com", + "SEP-10 Client Domain: vibrantapp.com", } logs := buf.String() @@ -152,7 +152,7 @@ func Test_SetupWalletsForProperNetwork(t *testing.T) { Name: "Vibrant Assist", Homepage: "https://vibrantapp.com/vibrant-assist", DeepLinkSchema: "https://aidpubnet.netlify.app", - SEP10ClientDomain: "api.vibrantapp.com", + SEP10ClientDomain: "vibrantapp.com", Assets: []data.Asset{ { Code: "USDC", @@ -241,7 +241,7 @@ func Test_SetupWalletsForProperNetwork(t *testing.T) { "Name: Vibrant Assist", "Homepage: https://vibrantapp.com/vibrant-assist", "Deep Link Schema: https://aidpubnet.netlify.app", - "SEP-10 Client Domain: api.vibrantapp.com", + "SEP-10 Client Domain: vibrantapp.com", "Assets:", "* USDC - GBBD47IF6LWK7P7MDEVSCWR7DPUWV3NY3DTQEVFL4NAT4AQH3ZLLFLA5", } diff --git a/internal/services/wallets/wallets_pubnet.go b/internal/services/wallets/wallets_pubnet.go index eda88ffce..4967eb873 100644 --- a/internal/services/wallets/wallets_pubnet.go +++ b/internal/services/wallets/wallets_pubnet.go @@ -7,7 +7,7 @@ var PubnetWallets = []data.Wallet{ Name: "Vibrant Assist", Homepage: "https://vibrantapp.com/vibrant-assist", DeepLinkSchema: "https://vibrantapp.com/sdp", - SEP10ClientDomain: "api.vibrantapp.com", + SEP10ClientDomain: "vibrantapp.com", Assets: []data.Asset{ { Code: "USDC", diff --git a/main.go b/main.go index 4521fd22e..32771ad60 100644 --- a/main.go +++ b/main.go @@ -11,7 +11,7 @@ import ( // Version is the official version of this application. Whenever it's changed // here, it also needs to be updated at the `helmchart/Chart.yaml#appVersion“. -const Version = "1.0.0" +const Version = "1.0.1" // GitCommit is populated at build time by // go build -ldflags "-X main.GitCommit=$GIT_COMMIT"