Skip to content

Commit

Permalink
Rust: allow large enum variants (#116)
Browse files Browse the repository at this point in the history
  • Loading branch information
leighmcculloch authored Jul 8, 2022
1 parent 285edb8 commit ca59a92
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions lib/xdrgen/generators/rust.rb
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ def render_union(out, union)
discriminant_type_builtin = is_builtin_type(union.discriminant.type) || (is_builtin_type(union.discriminant.type.resolved_type.type) if union.discriminant.type.respond_to?(:resolved_type) && AST::Definitions::Typedef === union.discriminant.type.resolved_type)
out.puts "// union with discriminant #{discriminant_type}"
out.puts "#[derive(Clone, Debug, Hash, PartialEq, Eq, PartialOrd, Ord)]"
out.puts "#[allow(clippy::large_enum_variant)]"
out.puts "pub enum #{name union} {"
out.indent do
union_cases(union) do |case_name, arm|
Expand Down
1 change: 1 addition & 0 deletions spec/output/generator_spec_rust/nesting.x/MyXDR.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1095,6 +1095,7 @@ self.foo.write_xdr(w)?;
//
// union with discriminant UnionKey
#[derive(Clone, Debug, Hash, PartialEq, Eq, PartialOrd, Ord)]
#[allow(clippy::large_enum_variant)]
pub enum MyUnion {
One(MyUnionOne),
Two(MyUnionTwo),
Expand Down
1 change: 1 addition & 0 deletions spec/output/generator_spec_rust/test.x/MyXDR.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1991,6 +1991,7 @@ impl WriteXdr for NesterNestedStruct {
//
// union with discriminant Color
#[derive(Clone, Debug, Hash, PartialEq, Eq, PartialOrd, Ord)]
#[allow(clippy::large_enum_variant)]
pub enum NesterNestedUnion {
Red,
}
Expand Down
2 changes: 2 additions & 0 deletions spec/output/generator_spec_rust/union.x/MyXDR.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1030,6 +1030,7 @@ Self::Multi => "Multi",
//
// union with discriminant UnionKey
#[derive(Clone, Debug, Hash, PartialEq, Eq, PartialOrd, Ord)]
#[allow(clippy::large_enum_variant)]
pub enum MyUnion {
Error(i32),
Multi(VecM::<i32>),
Expand Down Expand Up @@ -1111,6 +1112,7 @@ Self::Multi(v) => v.write_xdr(w)?,
//
// union with discriminant i32
#[derive(Clone, Debug, Hash, PartialEq, Eq, PartialOrd, Ord)]
#[allow(clippy::large_enum_variant)]
pub enum IntUnion {
V0(i32),
V1(VecM::<i32>),
Expand Down

0 comments on commit ca59a92

Please sign in to comment.