Merge pull request #39 from stellarwp/fix/return-remote-url-when-asset-is-remote

Return URL as the full path when URL was given

Author: dpanta94

Diff for: src/Assets/Asset.php

@@ -1115,13 +1115,25 @@ public function get_url( bool $use_min_if_available = true ): string {
 	 * Get the asset's full path - considering if minified exists.
 	 *
 	 * @since 1.4.6
+	 * @since 1.4.7 When the path is a URL, return the URL.
 	 *
 	 * @param bool $use_min_if_available
 	 *
 	 * @return string
 	 */
 	public function get_full_resource_path( bool $use_min_if_available = true ): string {
 		$resource_path_data = $this->build_resource_path_data();
+		if ( empty( $resource_path_data['resource'] ) ) {
+			return '';
+		}
+
+		if (
+			str_starts_with( $resource_path_data['resource'], 'http://' ) ||
+			str_starts_with( $resource_path_data['resource'], 'https://' ) ||
+			str_starts_with( $resource_path_data['resource'], '//' )
+		) {
+			return $resource_path_data['resource'];
+		}
 		$resource           = $resource_path_data['resource'];
 		$resource_path      = $resource_path_data['resource_path'];
 

Diff for: tests/wpunit/AssetsTest.php

@@ -298,6 +298,14 @@ public function it_should_get_the_correct_url_when_wp_content_dir_and_wp_content
 		}
 	}
 
+	/**
+	 * @test
+	 */
+	public function it_should_return_url_as_the_full_resource_path_when_the_path_is_a_url() {
+		$asset = Asset::add( 'fake-script', 'https://example.com/fake.js' );
+		$this->assertEquals( 'https://example.com/fake.js', $asset->get_full_resource_path() );
+	}
+
 	public function constantProvider() {
 		$data = [
 			[