fixed a rare case where assets urls are created invalid #35
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we found an rare case in which library return an invalid url.
some preconditions:
which this condition in file Config.php on method get_url the function str_replace trigger the transformation many time for the string.
this is te our test env
wp_list_pluck( $bases, 'base_dir' ) return
wp_list_pluck( $bases, 'base_url' ) return
the transformation return
http:/http:/http://miodominiouno.it/ita/wp-content/plugins/the-events-calendar/common/
we have made a test using strtr that perform only one substitution and the code works.
We attach a 1 line patch