Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: improve nodeResolve config #6203

Merged
merged 4 commits into from
Mar 13, 2025
Merged

build: improve nodeResolve config #6203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
084aa90
fix(build): expand nodeResolve export conditions to include `require`
Mar 13, 2025
38e586b
chore: nodeResolve - allow user config to take precedence over defaul…
Mar 13, 2025
badc594
chore: tweak
Mar 13, 2025
1f577d1
chore: untweak :D
Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/compiler/bundle/bundle-output.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,11 @@ export const getRollupOptions = (
): RollupOptions => {
const nodeResolvePlugin = rollupNodeResolvePlugin({
mainFields: ['collection:main', 'jsnext:main', 'es2017', 'es2015', 'module', 'main'],
browser: true,
browser: bundleOpts.platform !== 'hydrate',
rootDir: config.rootDir,
...(config.nodeResolve as any),
exportConditions: ['default', 'module', 'import', 'require'],
extensions: ['.tsx', '.ts', '.mts', '.cts', '.js', '.mjs', '.cjs', '.json', '.d.ts', '.d.mts', '.d.cts'],
...config.nodeResolve,
});

// @ts-expect-error - this is required now.
Expand Down
16 changes: 10 additions & 6 deletions src/declarations/stencil-public-compiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1772,15 +1772,19 @@ export interface BundlingConfig {
}

export interface NodeResolveConfig {
module?: boolean;
jsnext?: boolean;
main?: boolean;
exportConditions?: string[];
browser?: boolean;
extensions?: string[];
preferBuiltins?: boolean;
moduleDirectories?: string[];
modulePaths?: string[];
dedupe?: string[] | ((importee: string) => boolean);
extensions?: readonly string[];
jail?: string;
only?: Array<string | RegExp>;
mainFields?: readonly string[];
modulesOnly?: boolean;
preferBuiltins?: boolean | ((module: string) => boolean);
resolveOnly?: ReadonlyArray<string | RegExp> | null | ((module: string) => boolean);
rootDir?: string;
allowExportsFolderMapping?: boolean;

// TODO(STENCIL-1107): Remove this field [BREAKING_CHANGE]
/**
Expand Down