chore(repo): stub automated production releases #472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit creates the initial pass at automated production releases for the repo. it is capable of: 1. building stencil store 2. versioning the library based on user input 3. logging the gneerated change to the console 4. generating and pushing a commit to _a_ branch the intent of this commit is to validate some of the mechanics of user input before we start attempting to publish. the plan is for that to come in a later pr. unknown: it unknown if additional branch protection rules will hinder us from pushing to `main` once we try to do this "for real". we had some difficulty here with stencil-core, and may have it again here. we'll merge this to verify the input works as expected. we can try to derisk this by setting up similar branch protection rules on a dummy branch and proceed from there
rwaskiewicz
changed the title
|
Closing, learned some things doing this for the playwright package that I'd like to pivot to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
this project is manually published to npm. this is the first step in resolving that.
GitHub Issue Number: N/A
What is the new behavior?
this commit creates the initial pass at automated production releases
for the repo. it is capable of:
the intent of this commit is to validate some of the mechanics of user
input before we start attempting to publish. the plan is for that to
come in a later pr.
unknown: it unknown if additional branch protection rules will hinder
us from pushing to
mainonce we try to do this "for real". we hadsome difficulty here with stencil-core, and may have it again here.
we'll merge this to verify the input works as expected. we can try to
derisk this by setting up similar branch protection rules on a dummy
branch and proceed from there
Does this introduce a breaking change?
Testing
Prior to ec48da6, I was able to use
pushevents to verify everything passed/worked as expected. See https://github.com/ionic-team/stencil-store/actions/runs/7936243883 (note - it'll say 'dev build', I fixed that in 9fe4da1)Other information