Fix Swagger when running on a virtual root (not '/') #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give error on Read ApiConfigurations settings
Replaced retrieval of ApiConfiguration from AppSettings singleton with direct instantiation in TokenController and ApiStartup to resolve initialization order issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swagger always tries to use the API definition from /api/ even if the app is hosted in a virtual root. This PR adds the vroot path to the API definition location so this works correctly.
I built this against a 4.7 branch due to a NopCommerce issue that's preventing me from upgrading to 4.8 now.