maybe_skipped boolean

Author: stephenberry

include/glaze/core/reflect.hpp

@@ -218,44 +218,29 @@ namespace glz
    // The decayed type after get_member is called
    template <class T, size_t I>
    using field_t = std::remove_cvref_t<refl_t<T, I>>;
-
-   // MSVC requires this specialization, otherwise it will try to instatiate dead `if constexpr` branches for N == 0
-   template <opts Opts, class T>
-   struct object_info;
-
-   template <opts Opts, class T>
-      requires(reflect<T>::size == 0)
-   struct object_info<Opts, T>
-   {
-      static constexpr bool maybe_skipped = false;
-   };
-
+   
    template <opts Opts, class T>
-      requires(reflect<T>::size > 0)
-   struct object_info<Opts, T>
-   {
-      static constexpr auto N = reflect<T>::size;
-
-      static constexpr bool maybe_skipped = [] {
-         if constexpr (N > 0) {
-            if constexpr (Opts.skip_null_members) {
-               // if any type could be null then we might skip
-               return []<size_t... I>(std::index_sequence<I...>) {
-                  return ((detail::always_skipped<field_t<T, I>> || detail::null_t<field_t<T, I>>) || ...);
-               }(std::make_index_sequence<N>{});
-            }
-            else {
-               // if we have an always_skipped type then we return true
-               return []<size_t... I>(std::index_sequence<I...>) {
-                  return ((detail::always_skipped<field_t<T, I>>) || ...);
-               }(std::make_index_sequence<N>{});
-            }
+   inline constexpr bool maybe_skipped = [] {
+      if constexpr (reflect<T>::size > 0)
+      {
+         constexpr auto N = reflect<T>::size;
+         if constexpr (Opts.skip_null_members) {
+            // if any type could be null then we might skip
+            return []<size_t... I>(std::index_sequence<I...>) {
+               return ((detail::always_skipped<field_t<T, I>> || detail::null_t<field_t<T, I>>) || ...);
+            }(std::make_index_sequence<N>{});
          }
          else {
-            return false;
+            // if we have an always_skipped type then we return true
+            return []<size_t... I>(std::index_sequence<I...>) {
+               return ((detail::always_skipped<field_t<T, I>>) || ...);
+            }(std::make_index_sequence<N>{});
          }
-      }();
-   };
+      }
+      else {
+         return false;
+      }
+   }();
 }
 
 namespace glz::detail

include/glaze/json/write.hpp

@@ -1677,7 +1677,7 @@ namespace glz
                }();
 
                static constexpr auto padding = round_up_to_nearest_16(maximum_key_size<T> + write_padding_bytes);
-               if constexpr (object_info<Opts, T>::maybe_skipped) {
+               if constexpr (maybe_skipped<Opts, T>) {
                   bool first = true;
                   invoke_table<N>([&]<size_t I>() {
                      using val_t = field_t<T, I>;

tests/json_reflection_test/json_reflection_test.cpp

@@ -454,7 +454,7 @@ struct empty_t
 {};
 
 static_assert(glz::reflect<empty_t>::size == 0);
-static_assert(not glz::object_info<glz::opts{}, empty_t>::maybe_skipped);
+static_assert(not glz::maybe_skipped<glz::opts{}, empty_t>);
 
 suite empty_test = [] {
    "empty_t"_test = [] {