Server fix (#1431)

* Fix invalid notify check on response rather than request

* return null values rather than empty bodies

Author: stephenberry

include/glaze/rpc/repe/registry.hpp

@@ -108,7 +108,10 @@ namespace glz::repe
          out.header.length = sizeof(repe::header) + out.query.size() + out.body.size();
       }
       else {
-         out.body.clear();
+         const auto ec = write<Opts>(nullptr, out.body);
+         if (bool(ec)) [[unlikely]] {
+            out.header.error = true;
+         }
          out.query.clear();
          out.header.query_length = out.query.size();
          out.header.body_length = out.body.size();

tests/repe_test/repe_test.cpp

@@ -90,7 +90,7 @@ suite structs_of_functions = [] {
 
       repe::request_json(request, {.query = "/i"}, 42);
       server.call(request, response);
-      expect(response.body.empty()) << response.body;
+      expect(response.body == "null") << response.body;
 
       repe::request_json(request, {"/hello"});
       server.call(request, response);
@@ -113,7 +113,7 @@ suite structs_of_functions = [] {
 
       repe::request_json(request, {"/my_functions/void_func"});
       server.call(request, response);
-      expect(response.body.empty()) << response.body;
+      expect(response.body == "null") << response.body;
 
       repe::request_json(request, {"/my_functions/hello"});
       server.call(request, response);
@@ -129,7 +129,7 @@ suite structs_of_functions = [] {
 
       repe::request_json(request, {"/my_string"}, "Howdy!");
       server.call(request, response);
-      expect(response.body.empty());
+      expect(response.body == "null");
 
       repe::request_json(request, {"/my_string"});
       server.call(request, response);
@@ -173,7 +173,7 @@ suite structs_of_functions = [] {
 
       repe::request_json(request, {"/name"}, "Susan");
       server.call(request, response);
-      expect(response.body.empty()) << response.body;
+      expect(response.body == "null") << response.body;
 
       repe::request_json(request, {"/get_name"});
       server.call(request, response);
@@ -187,12 +187,12 @@ suite structs_of_functions = [] {
       repe::request_json(request, {"/set_name"}, "Bob");
       server.call(request, response);
       expect(obj.name == "Bob");
-      expect(response.body.empty()) << response.body;
+      expect(response.body == "null") << response.body;
 
       repe::request_json(request, {"/custom_name"}, "Alice");
       server.call(request, response);
       expect(obj.name == "Alice");
-      expect(response.body.empty()) << response.body;
+      expect(response.body == "null") << response.body;
    };
 };
 
@@ -218,7 +218,7 @@ suite structs_of_functions_beve = [] {
       repe::request_beve(request, {.query = "/i"}, 42);
       server.call(request, response);
       expect(!glz::beve_to_json(response.body, res));
-      expect(res.empty()) << res;
+      expect(res == "null") << res;
 
       repe::request_beve(request, {"/hello"});
       server.call(request, response);
@@ -246,7 +246,7 @@ suite structs_of_functions_beve = [] {
 
       std::string res{};
       expect(!glz::beve_to_json(response.body, res));
-      expect(res.empty()) << res;
+      expect(res == "null") << res;
 
       repe::request_beve(request, {"/my_functions/hello"});
       server.call(request, response);
@@ -266,7 +266,7 @@ suite structs_of_functions_beve = [] {
       repe::request_beve(request, {"/my_string"}, "Howdy!");
       server.call(request, response);
       expect(!glz::beve_to_json(response.body, res));
-      expect(res.empty());
+      expect(res == "null");
 
       repe::request_beve(request, {"/my_string"});
       server.call(request, response);
@@ -318,7 +318,7 @@ suite structs_of_functions_beve = [] {
 
       std::string res{};
       expect(!glz::beve_to_json(response.body, res));
-      expect(res.empty()) << res;
+      expect(res == "null") << res;
 
       repe::request_beve(request, {"/get_name"});
       server.call(request, response);
@@ -338,14 +338,14 @@ suite structs_of_functions_beve = [] {
 
       expect(!glz::beve_to_json(response.body, res));
       expect(obj.name == "Bob");
-      expect(res.empty()) << res;
+      expect(res == "null") << res;
 
       repe::request_beve(request, {"/custom_name"}, "Alice");
       server.call(request, response);
 
       expect(!glz::beve_to_json(response.body, res));
       expect(obj.name == "Alice");
-      expect(res.empty()) << res;
+      expect(res == "null") << res;
    };
 };
 
@@ -374,7 +374,7 @@ suite wrapper_tests = [] {
 
       repe::request_json(request, {"/sub/my_functions/void_func"});
       server.call(request, response);
-      expect(response.body.empty()) << response.body;
+      expect(response.body == "null") << response.body;
 
       repe::request_json(request, {"/sub/my_functions/hello"});
       server.call(request, response);
@@ -395,7 +395,7 @@ suite root_tests = [] {
 
       repe::request_json(request, {"/sub/my_functions/void_func"});
       server.call(request, response);
-      expect(response.body.empty()) << response.body;
+      expect(response.body == "null") << response.body;
 
       repe::request_json(request, {"/sub/my_functions/hello"});
       server.call(request, response);
@@ -420,7 +420,7 @@ suite wrapper_tests_beve = [] {
 
       std::string res{};
       expect(!glz::beve_to_json(response.body, res));
-      expect(res.empty()) << res;
+      expect(res == "null") << res;
 
       repe::request_beve(request, {"/sub/my_functions/hello"});
       server.call(request, response);