Simplify REPE error handling, remove from state

Author: stephenberry

include/glaze/json/read.hpp

@@ -234,9 +234,7 @@ namespace glz
          constexpr auto type = HashInfo.type;
          constexpr auto N = reflect<T>::size;
 
-         if constexpr (not bool(type)) {
-            static_assert(false_v<T>, "invalid hash algorithm");
-         }
+         static_assert(bool(type), "invalid hash algorithm");
 
          if constexpr (N == 1) {
             decode_index<Opts, T, 0>(value, ctx, it, end, selected_index...);
@@ -265,9 +263,19 @@ namespace glz
                   return;
                }
             }
-
-            // We see better performance with function pointers than a glz::jump_table here.
-            visit<N>([&]<size_t I>() { decode_index<Opts, T, I>(value, ctx, it, end, selected_index...); }, index);
+            
+            if constexpr (N == 2) {
+               if (index == 0) {
+                  decode_index<Opts, T, 0>(value, ctx, it, end, selected_index...);
+               }
+               else {
+                  decode_index<Opts, T, 1>(value, ctx, it, end, selected_index...);
+               }
+            }
+            else {
+               // We see better performance with function pointers than a glz::jump_table here.
+               visit<N>([&]<size_t I>() { decode_index<Opts, T, I>(value, ctx, it, end, selected_index...); }, index);
+            }
          }
       }
 

include/glaze/rpc/repe/registry.hpp

@@ -20,7 +20,6 @@ namespace glz::repe
    {
       repe::message& in;
       repe::message& out;
-      error_t& error;
 
       bool notify() const { return in.header.notify(); }
 
@@ -49,8 +48,7 @@ namespace glz::repe
       auto& in = state.in;
       auto& out = state.out;
       out.header.id = in.header.id;
-      if (state.error) {
-         out.header.error = true;
+      if (out.header.error) {
          out.header.query_length = out.query.size();
          out.header.body_length = out.body.size();
          out.header.length = sizeof(repe::header) + out.query.size() + out.body.size();
@@ -72,8 +70,7 @@ namespace glz::repe
       auto& in = state.in;
       auto& out = state.out;
       out.header.id = in.header.id;
-      if (state.error) {
-         out.header.error = true;
+      if (out.header.error) {
          out.header.query_length = out.query.size();
          out.header.body_length = out.body.size();
          out.header.length = sizeof(repe::header) + out.query.size() + out.body.size();
@@ -468,8 +465,12 @@ namespace glz::repe
       void call(message& in, message& out)
       {
          if (auto it = methods.find(in.query); it != methods.end()) {
-            static thread_local error_t error{};
-            it->second(state{in, out, error}); // handle the body
+            if (in.header.error) {
+               out = in;
+            }
+            else {
+               it->second(state{in, out}); // handle the body
+            }
          }
          else {
             static constexpr error_code code = error_code::method_not_found;