Removing default instantiation and cleaning (#1516)

* Removing default instantiation and cleaning

* fix variable rename

Author: stephenberry

include/glaze/json/escape_unicode.hpp

@@ -240,12 +240,13 @@ namespace glz
    template <string_literal Str>
    inline constexpr auto escape_unicode = []() constexpr -> std::string_view {
       constexpr auto escaped = []() constexpr {
-         constexpr auto output_length = detail::escaped_length(Str.sv());
-         std::array<char, output_length + 1> result{}; // + 1 for null character
-         const auto escaped = detail::escape_json_string(Str.sv(), output_length);
-         for (size_t i = 0; i < output_length; ++i) {
+         constexpr auto len = detail::escaped_length(Str.sv());
+         std::array<char, len + 1> result; // + 1 for null character
+         const auto escaped = detail::escape_json_string(Str.sv(), len);
+         for (size_t i = 0; i < len; ++i) {
             result[i] = escaped[i];
          }
+         result[len] = '\0';
          return result;
       }();
 

include/glaze/util/string_literal.hpp

@@ -81,12 +81,12 @@ namespace glz
       {
          constexpr auto joined_arr = []() {
             constexpr size_t len = (Strs.size() + ... + 0);
-            std::array<char, len + 1> arr{};
+            std::array<char, len + 1> arr;
             auto append = [i = 0, &arr](const auto& s) mutable {
                for (auto c : s) arr[i++] = c;
             };
             (append(Strs), ...);
-            arr[len] = 0;
+            arr[len] = '\0';
             return arr;
          }();
          auto& static_arr = make_static<joined_arr>::value;

include/glaze/util/tuple.hpp

@@ -15,17 +15,7 @@ namespace glz
    template <class T>
    concept is_std_tuple = is_specialization_v<T, std::tuple>;
 
-   // group builder code
-   template <size_t N>
-   constexpr auto shrink_index_array(auto&& arr)
-   {
-      std::array<size_t, N> res{};
-      for (size_t i = 0; i < N; ++i) {
-         res[i] = arr[i];
-      }
-      return res;
-   }
-
+   // TODO: This doesn't appear to be used. Should it be removed?
    template <class Type>
    concept is_schema_class = requires {
       requires std::is_class_v<Type>;