Removing macros #1614
Merged
Removing macros #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is looking good! Also, I'm just curious: Is it because bool fits in a register so compiler can optimize it well with a mov and a jmp without any additional checking or loading from memory? @stephenberry |
|
I think it is because the boolean is simpler for the compiler to see through. It is easy for the compiler to see that a boolean is being checked twice (to achieve a single path) and merge it into a single check. It is more complicated if a register is being modified, because there could be other side effects. |
|
I'm merging in these changes. @msqr1, let me know if there are more macros that I ought to eliminate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing macros for the sake of C++20 modules and easier debugging.