Skip to content

Commit

Permalink
podio: apply patch for gcc 14 builds
Browse files Browse the repository at this point in the history
Podio versions after 0.17.0 but before 1.0.0 are broken when using gcc
14 because of a missing include, which is addressed in the podio pull
request at AIDASoft/podio#600. This commit
patches pre-1.0.0 versions of Podio so they can be compiled with gcc 14,
which is important for building Acts.
  • Loading branch information
stephenswat committed Aug 21, 2024
1 parent 34df21b commit eec63cc
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
From 0222a077aaff817b21a46a590af0f8329dd27d67 Mon Sep 17 00:00:00 2001
From: Juan Miguel Carceller <22276694+jmcarcell@users.noreply.github.com>
Date: Mon, 13 May 2024 14:04:08 +0200
Subject: [PATCH] Add include to fix building with GCC 14 (#600)

Co-authored-by: jmcarcell <jmcarcell@users.noreply.github.com>
---
src/DatamodelRegistryIOHelpers.cc | 1 +
1 file changed, 1 insertion(+)

diff --git a/src/DatamodelRegistryIOHelpers.cc b/src/DatamodelRegistryIOHelpers.cc
index 901dbb113..1e7573a1f 100644
--- a/src/DatamodelRegistryIOHelpers.cc
+++ b/src/DatamodelRegistryIOHelpers.cc
@@ -1,4 +1,5 @@
#include "podio/utilities/DatamodelRegistryIOHelpers.h"
+#include <algorithm>
#include <iterator>
2 changes: 2 additions & 0 deletions var/spack/repos/builtin/packages/podio/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ class Podio(CMakePackage):

conflicts("+rntuple", when="@:0.16", msg="rntuple support requires at least podio@0.17")

patch("fix_missing_algorithm_include.patch", when="@0.17.0:0.100")

# See https://github.com/AIDASoft/podio/pull/599 that landed after 0.99
extends("python", when="@1.0:")

Expand Down

0 comments on commit eec63cc

Please sign in to comment.