Do not use permanent when reading from cookies (#91)

When we want to store a permanent cookie, we have to use the `permanent` accessor. When reading, this is not needed. See [documentation (https://api.rubyonrails.org/classes/ActionDispatch/Cookies/ChainedCookieJars.html#method-i-permanent) :

> This jar is only meant for writing. You'll read permanent cookies through the regular accessor.

When we want to check for a cookie existence, instead of doing:

`cookies.encrypted[:remember_token].present?`

we can do just:

`cookies[:remember_token]`

Author: fredplante

README.md

@@ -1113,8 +1113,8 @@ module Authentication
   def current_user
     Current.user ||= if session[:current_user_id].present?
       User.find_by(id: session[:current_user_id])
-    elsif cookies.permanent.encrypted[:remember_token].present?
-      User.find_by(remember_token: cookies.permanent.encrypted[:remember_token])
+    elsif cookies[:remember_token]
+      User.find_by(remember_token: cookies.encrypted[:remember_token])
     end
   end
   ...
@@ -1373,8 +1373,8 @@ module Authentication
   def current_user
     Current.user = if session[:current_active_session_id].present?
       ActiveSession.find_by(id: session[:current_active_session_id]).user
-    elsif cookies.permanent.encrypted[:remember_token].present?
-      User.find_by(remember_token: cookies.permanent.encrypted[:remember_token])
+    elsif cookies[:remember_token]
+      User.find_by(remember_token: cookies.encrypted[:remember_token])
     end
   end
   ...
@@ -1586,8 +1586,8 @@ module Authentication
   def current_user
     Current.user = if session[:current_active_session_id].present?
       ActiveSession.find_by(id: session[:current_active_session_id])&.user
-    elsif cookies.permanent.encrypted[:remember_token].present?
-      User.find_by(remember_token: cookies.permanent.encrypted[:remember_token])
+    elsif cookies[:remember_token]
+      User.find_by(remember_token: cookies.encrypted[:remember_token])
     end
   end
   ...
@@ -1675,16 +1675,16 @@ module Authentication
   end
   ...
   def remember(active_session)
-    cookies.permanent.encrypted[:remember_token] = active_session.remember_token
+    cookies.encrypted[:remember_token] = active_session.remember_token
   end
   ...
   private
 
   def current_user
     Current.user = if session[:current_active_session_id].present?
       ActiveSession.find_by(id: session[:current_active_session_id])&.user
-    elsif cookies.permanent.encrypted[:remember_token].present?
-      ActiveSession.find_by(remember_token: cookies.permanent.encrypted[:remember_token])&.user
+    elsif cookies[:remember_token]
+      ActiveSession.find_by(remember_token: cookies.encrypted[:remember_token])&.user
     end
   end
   ...

app/controllers/concerns/authentication.rb

@@ -43,8 +43,8 @@ def remember(active_session)
   def current_user
     Current.user = if session[:current_active_session_id].present?
       ActiveSession.find_by(id: session[:current_active_session_id])&.user
-    elsif cookies.permanent.encrypted[:remember_token].present?
-      ActiveSession.find_by(remember_token: cookies.permanent.encrypted[:remember_token])&.user
+    elsif cookies[:remember_token]
+      ActiveSession.find_by(remember_token: cookies.encrypted[:remember_token])&.user
     end
   end
 

test/test_helper.rb

@@ -13,8 +13,7 @@ class ActiveSupport::TestCase
   def current_user
     if session[:current_active_session_id].present?
       ActiveSession.find_by(id: session[:current_active_session_id])&.user
-    else
-      cookies[:remember_token].present?
+    elsif cookies[:remember_token]
       ActiveSession.find_by(remember_token: cookies[:remember_token])&.user
     end
   end