Skip to content
This repository was archived by the owner on Dec 16, 2018. It is now read-only.

Adding support for CI 3 and SyslogUDPHandler for external log systems like papertrail #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cumanzorx07
Copy link

  • Changes /libraries/Log.php to /core/MY_Log.php for CI 3 compatibility
  • Add SyslogUDPHandler in order to support External UDP log receivers like papertrail

Copy link
Owner

@stevethomas stevethomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @cumanzorx07

  1. Can you remove the .idea files? They should not be versioned.

  2. You have fixed the monolog version in composer, there is no reason to not allow updates within the 1.x.x branch.

  3. I don't work with CodeIgniter much anymore, are you sure this still works with 2.0 as well? It may be better to push to a new version 3 branch instead.

@cumanzorx07
Copy link
Author

cumanzorx07 commented Dec 5, 2017

Hi @stevethomas , here are my answers to each question.

  1. Whoops!!! I think I blindly commited those files
  2. Whoops!!! x2.
  3. You are right, this won't work in CI 2.0, the core files are only functional in 3.x

Let me do the adjustments and I will let you know

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants