Scatter fix to keep same domains after filtering samples #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m effect when filtering and helps to compare plots
xzhou82
reviewed
Feb 20, 2025
server/src/termdb.matrix.js
Outdated
| @@ -161,11 +161,11 @@ async function getSampleData(q, ds, onlyChildren = false) { | |||
| filter0: q.filter0 | |||
| } | |||
| const data = await q.ds.queries[tw.term.type].get(args) | |||
| for (const sampleId in data.term2sample2value.get(tw.term.name)) { | |||
| for (const sampleId in data.term2sample2value[tw.term.name]) { | |||
There was a problem hiding this comment.
this is map not obj. this breaks gene exp overlay
There was a problem hiding this comment.
Fixed now. Some how I got confused trying to fix a gene expression scatter. Here it is the error I see adding a gender filter here
There was a problem hiding this comment.
data looks like this then
data { term2sample2value: Set(0) {}, byTermId: {}, bySampleId: {} }
There was a problem hiding this comment.
I added a fix to avoid that error in my last commit
xzhou82
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scatter fix to keep same scale domains after filtering samples. Misc fixes. Closes #674
Checklist
Check each task that has been performed or verified to be not applicable.