Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mds3 tk cnv legend will handle case when no cnv data is present … #2864

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

xzhou82
Copy link
Collaborator

@xzhou82 xzhou82 commented Feb 21, 2025

…due to server error and not to crash

Description

closes #2863
fixes a problem Jian ran into in his branch (merge this first then rebase your on master)

test link, to break it, at line 1224 of mds3.init.js, change to bcfArgs.push('-s', l.join(',')+',xx') which causes an invalid sample name to be added to bcftools query command and triggers an error

the fix allows the error msg to be displayed in track body

Checklist

Check each task that has been performed or verified to be not applicable.

  • Tests: added and/or passed unit and integration tests, or N/A
  • Todos: commented or documented, or N/A
  • Notable Changes: updated release.txt, prefixed a commit message with "fix:" or "feat:", added to an internal tracking document, or N/A

@xzhou82 xzhou82 requested a review from josephpowi February 21, 2025 21:30
@xzhou82 xzhou82 merged commit fadfbc0 into master Feb 22, 2025
3 checks passed
@xzhou82 xzhou82 deleted the issue.2863 branch February 22, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mds3 tk cnv legend crashes
1 participant