Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip apply default scatterplot config #2866

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

wip apply default scatterplot config #2866

wants to merge 1 commit into from

Conversation

xzhou82
Copy link
Collaborator

@xzhou82 xzhou82 commented Feb 21, 2025

Description

closes #2865
also addresses a type error

Checklist

Check each task that has been performed or verified to be not applicable.

  • Tests: added and/or passed unit and integration tests, or N/A
  • Todos: commented or documented, or N/A
  • Notable Changes: updated release.txt, prefixed a commit message with "fix:" or "feat:", added to an internal tracking document, or N/A

@xzhou82 xzhou82 requested a review from airenzp February 21, 2025 22:53
@xzhou82 xzhou82 marked this pull request as draft February 21, 2025 22:53
@xzhou82
Copy link
Collaborator Author

xzhou82 commented Feb 21, 2025

could you check out this fix? color gradient no longer works

startColor: {}, //dict to store the start color of the gradient for each chart when using continuous color
stopColor: {} //dict to store the stop color of the gradient for each chart when using continuous color
sampleScatter: getDefaultScatterSettings()
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You moved the startColor and stopColor out of the settings and into the config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default configs are not applied to samplescatter
2 participants