Add fromYAML/toYAML functions
#193
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pkg/templates/templates.go
Outdated
| newMatchStr = strings.Replace(newMatchStr, "toYaml", fmt.Sprintf("toYaml | indent %d", numSpaces), 1) | ||
| newMatchStr = strings.Replace(newMatchStr, "toYAML", fmt.Sprintf("toYAML | indent %d", numSpaces), 1) |
There was a problem hiding this comment.
/hold I realized this replacement doesn't account for the toYAML argument--I'll have to adjust it to a RegEx replacement.
There was a problem hiding this comment.
This is resolved as a known issue and this block has been removed. Helm also notes that indentation processing can't be handled by the template processor and must be specified by the user. I'll create an issue to add hints/suggestions to error messages in this case.
// The output will not be indented, so you will want to pipe this to the
// 'indent' template function.There was a problem hiding this comment.
New issue opened for error message hints: https://issues.redhat.com/browse/ACM-20011
dhaiducek
force-pushed
the
19746-fromYAML
branch
2 times, most recently
from
3389297 to
11c3b61
Compare
|
/unhold |
ref: https://issues.redhat.com/browse/ACM-19746 Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
I found having results on a separate line made it easier to parse. Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Some of our RegEx expressions didn't account for the `-}}` syntax Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
dhaiducek
force-pushed
the
19746-fromYAML
branch
from
11c3b61 to
e762501
Compare
|
fromYAMLwas straightforward, buttoYAMLbrought complexities:toYAMLto the autoindent processing because it will result in a multiline string.That said, I might be okay if
toYAMLwere just not available (sincetoJSONlikely works more reliably) or iftoYAMLjust pointed totoJSON, though there are cases where users might want to be able to generate YAML (like inobject-templates-rawor in a ConfigMap).I also noticed some of our RegExs were missing the Go template whitespace chomping character
-}}, which affected one of the tests I wrote.ref: https://issues.redhat.com/browse/ACM-19746