Upgrade golangci-lint to v1.64.8

All above these version:
github.com/golangci/golangci-lint/cmd/golangci-lint@v1.55.1
github.com/daixiang0/gci@v0.11.2
sigs.k8s.io/kustomize/kustomize/v5@v5.2.1
gosec => 2.22.2
kustomize => 5.6
https://issues.redhat.com/browse/ACM-8341
Ref: https://issues.redhat.com/browse/ACM-8341
Signed-off-by: yiraeChristineKim <yikim@redhat.com>

Author: yiraeChristineKim

Diff for: build/common/Makefile.common.mk

@@ -5,15 +5,15 @@
 # https://github.com/kubernetes-sigs/controller-tools/releases/latest
 CONTROLLER_GEN_VERSION := v0.16.3
 # https://github.com/kubernetes-sigs/kustomize/releases/latest
-KUSTOMIZE_VERSION := v5.4.3
+KUSTOMIZE_VERSION := v5.6.0
 # https://github.com/golangci/golangci-lint/releases/latest
-GOLANGCI_VERSION := v1.52.2
+GOLANGCI_VERSION := v1.64.8
 # https://github.com/mvdan/gofumpt/releases/latest
 GOFUMPT_VERSION := v0.7.0
 # https://github.com/daixiang0/gci/releases/latest
 GCI_VERSION := v0.13.5
 # https://github.com/securego/gosec/releases/latest
-GOSEC_VERSION := v2.21.3
+GOSEC_VERSION := v2.22.2
 # https://github.com/kubernetes-sigs/kubebuilder/releases/latest
 KBVERSION := 3.15.1
 # https://github.com/kubernetes/kubernetes/releases/latest

Diff for: build/common/config/.golangci.yml

@@ -24,6 +24,7 @@ run:
 linters:
   enable-all: true
   disable:
+    - mnd  # Disabled as tech debt: Magic number detection
     - bodyclose
     - cyclop
     - deadcode #deprecated

Diff for: test/common/common.go

@@ -184,7 +184,7 @@ func LoadConfig(url, kubeconfig, context string) (*rest.Config, error) {
 		}
 	}
 
-	return nil, fmt.Errorf("could not create a valid kubeconfig")
+	return nil, errors.New("could not create a valid kubeconfig")
 }
 
 func oc(args ...string) (string, error) {
@@ -212,7 +212,7 @@ func oc(args ...string) (string, error) {
 			return string(output), nil
 		}
 
-		return string(output), fmt.Errorf(string(exitError.Stderr))
+		return string(output), errors.New(string(exitError.Stderr))
 	}
 
 	return string(output), err
@@ -287,8 +287,8 @@ func IsAtLeastVersion(minVersion string) bool {
 	klog.V(5).Info("OCP Version " + version)
 
 	// Convert to valid semantic versions by adding the "v" prefix
-	minSemVer := fmt.Sprintf("v%s", minVersion)
-	ocpSemVer := semver.MajorMinor(fmt.Sprintf("v%s", version))
+	minSemVer := "v" + minVersion
+	ocpSemVer := semver.MajorMinor("v" + version)
 
 	// Compare returns: 0 if ver1 == ver2, -1 if ver1 < ver2, or +1 if ver1 > ver2
 	return semver.Compare(ocpSemVer, minSemVer) >= 0

Diff for: test/common/metrics.go

@@ -39,6 +39,7 @@ func GetWithToken(url, authToken string) (body, status string, err error) {
 	if err != nil {
 		return "", "", err
 	}
+
 	defer resp.Body.Close()
 	bodyBytes, err := io.ReadAll(resp.Body)
 

Diff for: test/common/policy_utils.go

@@ -7,6 +7,7 @@ import (
 	"errors"
 	"fmt"
 	"path/filepath"
+	"strconv"
 	"strings"
 
 	. "github.com/onsi/ginkgo/v2"
@@ -389,12 +390,12 @@ func DoHistoryUpdatedTest(policyName string, messages ...string) {
 		g.Expect(err).ShouldNot(HaveOccurred())
 		lenMessage := len(messages)
 		historyMsgs := []string{}
-		fmt.Println("Returned policy history:")
+		GinkgoWriter.Println("Returned policy history:")
 		for i, h := range history {
 			historyItem, _ := h.(map[string]interface{})
 			m, _, _ := unstructured.NestedString(historyItem, "message")
 			historyMsgs = append(historyMsgs, m)
-			fmt.Println(fmt.Sprint(i) + ": " + m)
+			GinkgoWriter.Println(strconv.Itoa(i) + ": " + m)
 		}
 		By("Check history length is same")
 		g.Expect(history).Should(HaveLen(lenMessage))

Diff for: test/common/user_management.go

@@ -6,6 +6,7 @@ import (
 	"context"
 	cryptoRand "crypto/rand"
 	"encoding/hex"
+	"errors"
 	"fmt"
 	"math/rand"
 	"os"
@@ -66,14 +67,14 @@ func GetKubeConfig(server, username, password string) (string, error) {
 	// Create a temporary file for the kubeconfig that the `oc login` command will generate
 	f, err := os.CreateTemp("", "e2e-kubeconfig")
 	if err != nil {
-		return "", fmt.Errorf("failed to create the temporary kubeconfig")
+		return "", errors.New("failed to create the temporary kubeconfig")
 	}
 
 	kubeconfigPath := f.Name()
 	// Close the file immediately so that the `oc login` command can use the file
 	err = f.Close()
 	if err != nil {
-		return "", fmt.Errorf("failed to close the temporary kubeconfig")
+		return "", errors.New("failed to close the temporary kubeconfig")
 	}
 
 	ctx, cancel := context.WithTimeout(context.Background(), time.Second*20)

Diff for: test/configuration_policy_prune.go

@@ -116,7 +116,7 @@ func ConfigPruneBehavior(labels ...string) bool {
 			g.Expect(err).ToNot(HaveOccurred())
 
 			return createdByPolicy
-		}, DefaultTimeoutSeconds, 5).Should(Equal(true), "createdByPolicy should be true")
+		}, DefaultTimeoutSeconds, 5).Should(BeTrue(), "createdByPolicy should be true")
 
 		DoCleanupPolicy(policyYaml, GvrConfigurationPolicy)
 
@@ -425,6 +425,7 @@ func ConfigPruneBehavior(labels ...string) bool {
 		"Test configuration policy pruning", Ordered, Label(labels...), func() {
 		cleanConfigMap := func() {
 			By("Removing any finalizers from the configmap")
+
 			_, _ = OcManaged("patch", "configmap", pruneConfigMapName, "-n", "default",
 				"--type=json", "-p", `[{"op":"remove", "path":"/metadata/finalizers"}]`)
 

Diff for: test/integration/policy_comp_operator_test.go

@@ -5,7 +5,6 @@ package integration
 
 import (
 	"context"
-	"fmt"
 
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
@@ -22,6 +21,7 @@ func complianceScanTest(scanPolicyName string, scanPolicyURL string, scanName st
 	Describe("create and enforce the stable/"+scanPolicyName+" policy", Ordered, Label("BVT"), func() {
 		It("stable/"+scanPolicyName+" should be created on hub", func(ctx SpecContext) {
 			By("Creating policy on hub")
+
 			_, err := utils.KubectlWithOutput(
 				"apply",
 				"-f",
@@ -136,6 +136,7 @@ func complianceScanTest(scanPolicyName string, scanPolicyURL string, scanName st
 	})
 	AfterAll(func() {
 		By("Removing policy")
+
 		_, err := utils.KubectlWithOutput(
 			"delete",
 			"-f",
@@ -289,7 +290,7 @@ var _ = Describe("RHACM4K-2222 GRC: [P1][Sev1][policy-grc] "+
 			i := 0
 			Eventually(func(g Gomega) []corev1.Pod {
 				if i == 60*2 || i == 60*4 {
-					fmt.Println("compliance operator pod still not created, "+
+					GinkgoWriter.Println("compliance operator pod still not created, "+
 						"deleting subscription and let it recreate", i)
 					_, err := utils.KubectlWithOutput(
 						"get", "-n",
@@ -420,7 +421,7 @@ var _ = Describe("RHACM4K-2222 GRC: [P1][Sev1][policy-grc] "+
 			"--ignore-not-found",
 		)
 		if err != nil {
-			Expect(err).To(Equal("error: the server doesn't have a resource type \"ProfileBundle\""))
+			Expect(err.Error()).To(Equal("error: the server doesn't have a resource type \"ProfileBundle\""))
 		} else {
 			Expect(err).ToNot(HaveOccurred())
 		}

Diff for: test/integration/policy_generator_acm_hardening_test.go

@@ -4,7 +4,7 @@ package integration
 
 import (
 	"context"
-	"fmt"
+	"errors"
 
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
@@ -110,9 +110,9 @@ var _ = Describe("GRC: [P1][Sev1][policy-grc] Test the ACM Hardening "+
 						return myerr
 					}
 					if !found {
-						return fmt.Errorf("failed to find the compliant field of the policy status")
+						return errors.New("failed to find the compliant field of the policy status")
 					} else if compliant != "Compliant" {
-						return fmt.Errorf("The policy is not compliant")
+						return errors.New("The policy is not compliant")
 					}
 				}
 

Diff for: test/integration/policy_report_metric_test.go

@@ -289,13 +289,13 @@ var _ = Describe("GRC: [P1][Sev1][policy-grc] Test policyreport_info metric", Or
 				strings.TrimSpace(insightsToken),
 			)
 			if err != nil {
-				fmt.Println("ERROR GETTING METRIC:")
-				fmt.Println(err)
+				GinkgoWriter.Println("ERROR GETTING METRIC:")
+				GinkgoWriter.Println(err)
 
 				return err
 			}
-			fmt.Println("metric response received:")
-			fmt.Println(resp)
+			GinkgoWriter.Println("metric response received:")
+			GinkgoWriter.Println(resp)
 
 			return resp
 		}, 10*time.Minute, 1).Should(common.MatchMetricValue(insightsMetricName, policyLabel, "1"))
@@ -322,13 +322,14 @@ var _ = Describe("GRC: [P1][Sev1][policy-grc] Test policyreport_info metric", Or
 				strings.TrimSpace(insightsToken),
 			)
 			if err != nil {
-				fmt.Println("ERROR GETTING METRIC:")
-				fmt.Println(err)
+				GinkgoWriter.Println("ERROR GETTING METRIC:")
+				GinkgoWriter.Println(err)
 
 				return err
 			}
-			fmt.Println("metric response received:")
-			fmt.Println(resp)
+
+			GinkgoWriter.Println("metric response received:")
+			GinkgoWriter.Println(resp)
 
 			return resp
 		}, 10*time.Minute, 1).ShouldNot(common.MatchMetricValue(insightsMetricName, policyLabel, "1"))

Diff for: test/performance/performance.go

@@ -58,12 +58,12 @@ func query(host string, token string, query string, insecure bool) (time.Time, f
 	}
 
 	trHeader := NewWithHeader(tr)
-	trHeader.Set("Authorization", fmt.Sprintf("Bearer %s", token))
+	trHeader.Set("Authorization", "Bearer "+token)
 
 	cl := &http.Client{Transport: trHeader}
 
 	client, err := api.NewClient(api.Config{
-		Address: fmt.Sprintf("https://%s", host),
+		Address: "https://" + host,
 		Client:  cl,
 	})
 	if err != nil {
@@ -263,7 +263,7 @@ func printTable(data []metricData) {
 	fmt.Fprintln(table, "========\t==========\t====================\t"+
 		"====================\t===================\t===================\t")
 
-	for i := 0; i < len(data); i++ {
+	for i := range data {
 		fmt.Fprintf(table, "%s\t%d\t%s\t%s\t%s\t%s\t\n",
 			data[i].timestamp,
 			data[i].numPolicies,
@@ -286,7 +286,7 @@ func printTable(data []metricData) {
 	fmt.Fprintln(table, "========\t==========\t====================\t"+
 		"====================\t===================\t===================\t")
 
-	for i := 0; i < len(data); i++ {
+	for i := range data {
 		fmt.Fprintf(table, "%s\t%d\t%s\t%s\t%s\t%s\t\n",
 			data[i].timestamp,
 			data[i].numPolicies,
@@ -330,7 +330,7 @@ func exportTable(cpuData []metricData, filename string) {
 	for _, entry := range cpuData {
 		line = []string{
 			entry.timestamp,
-			fmt.Sprintf("%d", entry.numPolicies),
+			strconv.Itoa(entry.numPolicies),
 			fmt.Sprintf("%.5f", entry.controllerCPUAvg),
 			fmt.Sprintf("%.5f", entry.controllerCPUMax),
 			fmt.Sprintf("%.5f", entry.apiServerCPUAvg),
@@ -396,7 +396,7 @@ func main() {
 
 		batchFails := 0
 
-		for batchPlcs := 0; batchPlcs < nPerBatch; batchPlcs++ {
+		for range nPerBatch {
 			err = genUniquePolicy(path.Join(performanceDir, plcFilename), path.Join(policyDir, "current_policy.yaml"))
 			if err != nil {
 				klog.Exitf("Error patching policy with unique name: %s", err)
@@ -413,12 +413,13 @@ func main() {
 
 					tries--
 					if tries == 0 {
-						os.Exit(1)
+						klog.Fatal()
 					}
 				} else {
 					break
 				}
 			}
+
 			totalPlcs++
 		}
 

Diff for: test/policy_ordering.go

@@ -130,6 +130,7 @@ func PolicyOrdering(labels ...string) bool {
 		Describe("Ordering via a dependency on a PolicySet", Ordered, func() {
 			It("Should create policyset with noncompliant status", func() {
 				By("Creating the initial policy set to use as a dependency")
+
 				_, err := OcHub("apply", "-f", testPolicySetYaml, "-n", UserNamespace)
 				Expect(err).ToNot(HaveOccurred())
 
@@ -167,6 +168,7 @@ func PolicyOrdering(labels ...string) bool {
 				Expect(plcSet).NotTo(BeNil())
 
 				By("Checking the status of policy set - NonCompliant")
+
 				yamlPlc := utils.ParseYaml("../resources/policy_ordering/dep-plcset-statuscheck.yaml")
 
 				Eventually(func() interface{} {