Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SVT test for standalone-hub-templating #915

Merged
merged 1 commit into from
Apr 4, 2025
Merged

Add SVT test for standalone-hub-templating #915

merged 1 commit into from
Apr 4, 2025

Conversation

JustinKuli
Copy link
Contributor

The test verifies the special message emitted when the addon is not enabled, as well as behavior around configuring "special" RBAC.

Refs:

@openshift-ci openshift-ci bot requested review from dhaiducek and gparvin March 24, 2025 13:30
@JustinKuli JustinKuli force-pushed the 16137-standalone-hub-template-test branch from 3768b11 to 10c0847 Compare March 24, 2025 13:33
@JustinKuli
Copy link
Contributor Author

/ok-to-test

@JustinKuli
Copy link
Contributor Author

/test remaining-required

@JustinKuli
Add SVT test for standalone-hub-templating
165d8ce 
The test verifies the special message emitted when the addon is not
enabled, as well as behavior around configuring "special" RBAC.

Refs:
 - https://issues.redhat.com/browse/ACM-16137
 - https://issues.redhat.com/browse/ACM-16094

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
@JustinKuli JustinKuli force-pushed the 16137-standalone-hub-template-test branch from 10c0847 to 165d8ce Compare March 24, 2025 20:33
@JustinKuli
Copy link
Contributor Author

/retest

dhaiducek
dhaiducek approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@dhaiducek dhaiducek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I left a nit, but I don't really think it's consequential here, so I'm not holding it. Feel free to frantically hold it if you'd like! 😬

test/resources/standalone_hubtemplates/config-standalone-addon.yaml
Comment on lines +39 to +40
clusterSets:
- global
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) This isn't necessary. Omitting it will select all bound cluster sets.

test/resources/standalone_hubtemplates/config-standalone-rbac.yaml
Comment on lines +70 to +71
clusterSets:
- global
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Same with above)

@openshift-ci openshift-ci bot added the lgtm label Mar 28, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, JustinKuli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JustinKuli,dhaiducek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhaiducek
Copy link
Contributor

/test remaining-required

@dhaiducek
Copy link
Contributor

/retest

@dhaiducek
Copy link
Contributor

dhaiducek commented Mar 31, 2025 •
edited
Loading

/retest

 GRC: [P1][Sev1][policy-grc] Test install Operator When all defaults are used on the subscription test-op-47229 should be created and become compliant [BVT]
/go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_install_operator_test.go:513
  STEP: Verifying that the policy policy-test/test-op-47229 is Compliant @ 03/29/25 03:11:11.098
  [FAILED] in [It] - /go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_install_operator_test.go:517 @ 03/29/25 03:13:11.098
  STEP: Cleaning up the operator installation @ 03/29/25 03:13:11.098
  STEP: Verifying that the policy policy-test/cleanup-grcqeoptest-ns is Compliant @ 03/29/25 03:13:11.598
• [FAILED] [122.033 seconds]
GRC: [P1][Sev1][policy-grc] Test install Operator When all defaults are used on the subscription [It] test-op-47229 should be created and become compliant [BVT]
/go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_install_operator_test.go:513
  [FAILED] Timed out after 120.000s.
  The function passed to Eventually failed at /go/src/github.com/stolostron/governance-policy-framework/test/integration/utils_test.go:53 with:
  Expected
      <string>: NonCompliant
  to equal
      <string>: Compliant
  In [It] at: /go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_install_operator_test.go:517 @ 03/29/25 03:13:11.098

@JustinKuli
Copy link
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 66f365b into main Apr 4, 2025
10 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the 16137-standalone-hub-template-test branch April 4, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaiducek dhaiducek dhaiducek approved these changes

@gparvin gparvin Awaiting requested review from gparvin

Assignees

@dhaiducek dhaiducek

Labels
approved dco-signoff: yes lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JustinKuli @dhaiducek